[Auto] Add unit tests for craftd-core#110
Closed
rviannaoliveira wants to merge 12 commits intomainfrom
Closed
Conversation
- Add IMAGE_COMPONENT to CraftDComponentKey enum - Add CraftDContentScale enum (CROP, FIT, FILL_BOUNDS, FILL_WIDTH, FILL_HEIGHT, INSIDE, NONE) - Add ImageProperties data class with url, contentScale, contentDescription, actionProperties Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Compose: - Add toContentScale() extension mapping CraftDContentScale → ContentScale - Add CraftDImage composable with injectable imageLoader lambda - Add CraftDImageBuilder with injectable imageLoader constructor param XML: - Add CraftDImageComponent (AppCompatImageView wrapper) - Add CraftDImageComponentRender with injectable imageLoader - Register CraftDImageComponentRender in CraftDBuilderManager via optional imageLoader param Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Unit tests for ImageProperties serialization, toContentScale() and CraftDImageBuilder key - Updated docs/how-to-use/compose.md and view-system.md with CraftDImage usage examples - Registered CraftDImageBuilder (Coil) in Compose sample and CraftDImageComponentRender (Picasso) in XML sample - Added CraftDImage entry to dynamic.json - Switched app-sample-android to local craftd-xml project dependency - Added Coil 2.6.0 to libs.versions.toml - Deleted notes.md after context consumed Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Merge changes from main (unit tests, build-logic updates) into the feature branch. Resolved conflicts in CraftDComponentKeyTest (IMAGE_COMPONENT count) and CraftDContentScale (removed Compose annotations from commonMain). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ns from commonMain - Add ContentScale param to imageLoader lambda in CraftDImage and CraftDImageBuilder so the server-driven contentScale is actually applied when loading images - Map CraftDContentScale to ImageView.ScaleType in CraftDImageComponentRender (XML) - Remove @Stable/@immutable from ImageProperties (androidx.compose deps in commonMain) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Archive empty add-craftd-image change (2026-04-22) - Update tasks.md in 2026-04-13-add-craftd-image-android-kmp: - 1.4: remove @Stable/@immutable from ImageProperties (commonMain violation) - 2.2a: imageLoader lambda now includes ContentScale param - 3.2a: contentScale mapped to ImageView.scaleType in XML render - 4.3: correct description of what tests actually cover - 4.4: pending tests task for next propose Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Register CraftDImageBuilder with Coil 3 (KMP-compatible) AsyncImage in the CMP sample, mirroring the android sample setup. Adds coil3-compose to commonMain and coil3-network-okhttp to androidMain for network image loading. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated Unit Tests
Este PR foi gerado automaticamente pelo workflow Auto Generate Cover+Test usando a Claude API.
Evolução de cobertura
Arquivos cobertos
Como funciona
android_kmp/craftd-coreChecklist de revisão
./gradlew testDebugUnitTest)