chore(new-icons): Add pin & unpin icons#1066
Merged
Merged
Conversation
kunalpanchal
changed the title
🦋 Changeset detectedLatest commit: fb3a9b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-9q5oxp9da-clickhouse.vercel.app Built from commit: |
crisalbu
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
pinandunpinicons to the Click UI icon asset set using the repository SVG conversion workflow. The generated icon registries andIconNametype now include both new names.Note
Low Risk
Additive icon assets and type/registry wiring only; no runtime or security-sensitive logic changes.
Overview
Adds
pinandunpinto the Click UI icon set so consumers can render them via the sharedIconcomponent (name="pin"/name="unpin").New React SVG assets (
Pin.tsx,Unpin.tsx) follow the existingSVGAssetPropspattern.IconNameand the light/dark icon registries (IconsLight,IconsDark) are updated to include both names. A changeset records a minor bump for@clickhouse/click-ui.Reviewed by Cursor Bugbot for commit fb3a9b6. Bugbot is set up for automated code reviews on this repo. Configure here.