fix(qbit): match ClickHouse byte order for dimension > 8#1166
Merged
Conversation
serprex
force-pushed
the
fix-qbit-byte-order
branch
from
June 5, 2026 21:23
3d3c0b0 to
3e8635a
Compare
serprex
changed the title
serprex
commented
Jun 5, 2026
Row/Append placed element groups in natural byte order, CH reverses them within each FixedString plane
serprex
force-pushed
the
fix-qbit-byte-order
branch
from
June 5, 2026 21:29
3e8635a to
046362b
Compare
Member
Author
|
found while using ch-go as reference implementing QBit in clickhouse-c ClickHouse/clickhouse-c#9 |
SpencerTorres
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Row/Append placed element groups in natural byte order, CH reverses them within each FixedString plane
Checklist
Delete items not relevant to your PR: