Skip to content

Fix advanced smartphone recovery with active laptop screen - #88193

Merged
Maleclypse merged 2 commits into
CleverRaven:masterfrom
Relvl:smartphone-recovery-fix
Aug 3, 2026
Merged

Fix advanced smartphone recovery with active laptop screen#88193
Maleclypse merged 2 commits into
CleverRaven:masterfrom
Relvl:smartphone-recovery-fix

Conversation

@Relvl

@Relvl Relvl commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Bugfixes "Recognize screen-lit laptops during advanced smartphone recovery"

Purpose of change

Advanced recovery on locked smartphones only detected laptops with their screen turned off.

With the screen active, the laptop changes to laptop_screen_lit, so a powered laptop containing Hacking PRO was incorrectly rejected.

Closes #88158

Describe the solution

Allow the advanced recovery condition to accept either laptop or laptop_screen_lit.

Describe alternatives you've considered

Removing the device restriction would also avoid the issue, but would allow Hacking PRO on unrelated devices. Keeping explicit checks for both laptop states preserves the intended requirement.

Testing

Tested with a laptop containing Hacking PRO and sufficient power:

  • Advanced recovery is available with the laptop screen off.
  • Advanced recovery is available with the laptop screen on.
  • The recovery option remains unavailable without the required software or skill.

Additional context

Made new one PR with the same contents, due to wrong action on fork.

@github-actions github-actions Bot added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON EOC: Effects On Condition Anything concerning Effects On Condition astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 2, 2026
@Maleclypse
Maleclypse merged commit 16e5996 into CleverRaven:master Aug 3, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Laptop with active screen is not detected for advanced smartphone recovery

2 participants