Fix advanced smartphone recovery with active laptop screen - #88193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Recognize screen-lit laptops during advanced smartphone recovery"
Purpose of change
Advanced recovery on locked smartphones only detected laptops with their screen turned off.
With the screen active, the laptop changes to
laptop_screen_lit, so a powered laptop containing Hacking PRO was incorrectly rejected.Closes #88158
Describe the solution
Allow the advanced recovery condition to accept either
laptoporlaptop_screen_lit.Describe alternatives you've considered
Removing the device restriction would also avoid the issue, but would allow Hacking PRO on unrelated devices. Keeping explicit checks for both laptop states preserves the intended requirement.
Testing
Tested with a laptop containing Hacking PRO and sufficient power:
Additional context
Made new one PR with the same contents, due to wrong action on fork.