Feature: Support mana, stamina, and blood costs in crafting recipes

[Relvl]

Summary

Features "Allow crafting recipes to consume character resources"

Purpose of change

Allow recipes to require character resources in addition to tools and components.

This is intended for recipes and practice activities that should consume mana, stamina, or vitamins while progressing, such as magical crafting, strenuous training, or blood-based rituals.

Describe the solution

Adds a new optional recipe field:

    "character_resources": {
      "mana": 1000,
      "stamina": 1000,
      "vitamins": [
        {
          "vitamin": "blood",
          "value": 10000,
          "//": "Stage 4 hypovolemia begins below -20000 blood units.",
          "safe_level": -20000
        }
      ]
    }

Supported resources are mana, stamina, and vitamins.

Character resource costs scale linearly with batch size and are consumed gradually according to crafting progress. Before each progress increment, all required resources are checked together. If any resource cannot be consumed, the current crafting turn is rolled back in the same way as a failed tool-charge consumption.

Mana and stamina cannot be reduced below zero. Blood cannot be reduced past the threshold for critical hypovolemia.

For unattended recipe steps, the remaining character resource cost is consumed before the passive step begins, since resources cannot be drawn from the crafter while they are no longer actively working on the item.

Characters with DEBUG_HS are treated as having sufficient resources and do not consume them.

The crafting interface displays a new Character resources section below tools and components. A resource is displayed normally when the character currently has enough for the full recipe cost, and highlighted when the full amount is unavailable.

Describe alternatives you've considered

Character resources could have been represented as tool charges or pseudo-items, but that would not accurately model resources stored directly on the character and would require additional supporting items or special-case behavior.

Another option was to require the entire resource cost before crafting could begin. This would prevent recipes from using resources that regenerate during long crafts, so the implementation instead checks and consumes the required amount incrementally.

Testing

Tested recipes with separate mana, stamina, and vitamins costs, also together.

Verified that:

• character resources are displayed in the crafting interface;
• costs scale with batch size;
• resources are consumed progressively during crafting;
• the exact total cost is consumed by recipe completion;
• crafting progress is rolled back when the next resource payment cannot be made;
• no partial resource payment occurs when one of several required resources is unavailable;
• blood consumption stops before critical hypovolemia (before reaching safe_level);
• unattended steps consume the remaining cost before beginning;
• DEBUG_HS bypasses resource checks and consumption;
• recipes without character_resources retain their existing behavior;
• practice recipes can use character resource costs.

Additional context

The initial implementation intentionally supports only mana, stamina, and blood vitamins. Additional character resources can be added later when there is a concrete use case and agreed behavior for their availability and consumption.

[GuardianDll]

Firstly, instead of blood, just put vitamin with a separate specification of vitamin type being consumed, this will support much more than just blood, which will be useful for mods
Secondly, and this one is not a request, but an ask you can ignore, can you add a condition of character having at least X in specific stat? there is a use case in, for example,

Cataclysm-DDA/data/json/recipes/other/medical.json

Line 34 in c017f60

"//": "using brute force, so not very precise, but still relatively fast; can't make str requirement for the recipe; so assume relatively weak character tries to rip it",

, that would prefer to check character is strong enough to rip the clothes with bare arms, also again mods might benefit from it

In general, is there a reason to consume stamina specifically? training recipes already make character weary, after all

[Relvl]

Firstly, instead of blood, just put vitamin with a separate specification of vitamin type being consumed, this will support much more than just blood, which will be useful for mods

Yeah, that's a good idea! I'll update that soon.

Secondly, and this one is not a request, but an ask you can ignore, can you add a condition of character having at least X in specific stat? there is a use case in, for example,

Cataclysm-DDA/data/json/recipes/other/medical.json

Line 34 in c017f60

"//": "using brute force, so not very precise, but still relatively fast; can't make str requirement for the recipe; so assume relatively weak character tries to rip it",

, that would prefer to check character is strong enough to rip the clothes with bare arms, also again mods might benefit from it

That's a bit outside the scope of this feature, but I agree it would be useful. I'll make a separate PR for it.

In general, is there a reason to consume stamina specifically? training recipes already make character weary, after all

Welp. I have no answer :] Originally I only planned to support mana, but while looking through the available character resources I noticed stamina and thought, “why not?”... It didn't add much complexity to the implementation.

[Standing-Storm]

At last, vampire-only recipes (or an easier means of doing so) for XE

[mqrause]

Instead of using raw strings, check out the magic_energy_type enum.

[Relvl]

@GuardianDll I replaced blood crafting costs with generic vitamin costs; please review.

@mqrause I replaces string literals with enum; please review.

Updated initial comment.

[GuardianDll]

Please fix the CI errors first

[Relvl]

Yeah, I saw it, thanks. I'll fix it soon.

[Relvl]

Converted to draft: I will write a tests instead of recipe_debug.json

[github-actions]

Include What You Use

Suggested change

#include "magic_type.h"