Chainmail crafting QOL and volume fix - #88188
Open
ahhwatson wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
I have realized that the 'v' insert menu does in fact let you load a bag with links with minimal additional effort. And presumably also sand/dirt. I'm removing that part of this PR because it is unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Smaller chainmail links"
Purpose of change
As of #87006, lc_chain_link weighed an appropriate amount, but each individual link had a 250ml volume, which made it very easy to hit the items-per-tile limit since a single batch did not fit more than a handful in most containers.
Describe the solution
Set each link to have volume 1ml (which as it happens is the minimum allowed item volume),
and added extra recipes for chain link crafting that involve putting your chain links into zipper bags as you go (this is a rather common way for hobbyists to store chain links, and makes moving the links less of an ordeal).Also changed the in-game description of chain links to account for the way links get used elsewhere---one link is one item.
Describe alternatives you've considered
Implementing units smaller than 1ml to more closely represent the actual size of chainmail links (I'm trying to avoid c++; the volume back when these were first implemented was about .352 ml/link, and I see no reason to be skeptical of that number).
Changing lc_chain_link to represent several links instead of one (this is a decent idea, but would require a lot of changes and achieve very little).
Trying to make the approach from #84073 work on the bag recipe (and using powder paper bags or something) (pretty sure this is beyond my skillset).Implementing a json flag that allows certain small, grainy objects (sand, dirt, links) to be reloaded into containers as if they were water. (The longer I looked into this, the more I understood why charges must die. Definitely not worth implementing as a system until liquids are de-charged, assuming they ever will be, unless someone more capable than me comes up with a way.)Pressing 'v' to use the insert menu if I want to put a thing in a bag.
Testing
Opened a new world, spawned in crafting materials, made 10 batches of links in bags, dropped them, watched them not overflow into another tile, observed that they fit in the bags.
Additional context
If there's a way around the item crafting limit of 4096, it might also be worth doing for chain links---as it is, chain links can't be batch-crafted more than 9 batches at a time.