Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-5364
🛠 Changes
textto Slack payload to avoid warnings.branch.targetto SonarQube to limit review to new code.ℹ️ Context
Node 20 is being deprecated for GHA so everything that uses it needs to be bumped to 24.
We were getting warnings from the call to the Slack GHA for not including a
textfield as a fall back for when the more dynamic message couldn't be sent.SonarQube updated on their end and began surfacing problems in old, unrelated code to the present commit. Adding a branch target forces it to only examine the diff between the currently submitted code and the main branch. This was already done in the ci-workflow.
🧪 Validation
broken-link-check
https://github.com/CMSgov/dpc-static-site/actions/runs/24744129846
check_508_compliance
https://github.com/CMSgov/dpc-static-site/actions/runs/24744479689
deploy
https://github.com/CMSgov/dpc-static-site/actions/runs/24838213173/job/72704384051
ci-workflow
All tests passing on this PR. 🤞