TDS_3: use indices, and keep backward compatibility with handles - #8909
Draft
afabri wants to merge 216 commits into
Draft
TDS_3: use indices, and keep backward compatibility with handles#8909afabri wants to merge 216 commits into
afabri wants to merge 216 commits into
Conversation
…terator are generic enough
This reverts commit abacbe7.
- one for storage (compact container...) - and a second one with generic function independent of the storage implementation
…dles-GF' into pr/afabri/8909-1
…nly slightly faster
afabri
commented
Jun 12, 2026
| *it.second++ = d; // = tds().to_cell_descriptor(d); | ||
|
|
||
| auto check_this_facet_must_be_in_the_cz = [&](cell_descriptor cd, int i, bool on_boundary = false) { | ||
| if(!this_facet_must_be_in_the_cz || !the_facet_is_in_its_cz) return; |
Member
Author
There was a problem hiding this comment.
In vtune I see both lambdas. Before we performed the test of line above to decide if we call the lambda or not. I guess what we see in vtune is the parameters getting copied.
lrineau
reviewed
Jun 23, 2026
lrineau
reviewed
Jun 23, 2026
Member
Author
|
The benchmark of main: The benchmark of afabri:Triangulation_3-Handles-GF The benchmark of afabri:Triangulation_3-Indices-GF |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Instead of changing the API of TDS, Triangulation, and everything using it, this PR takes another approach:
We store indices in the data structures instead of handles, and generate the handles on the fly, which hold a pointer to the TDS and an index.
We also split
Triangulation_data_structure_3in two: A base class which knows about storage and index/vs pointer and provides an API with handles. And a derived class that uses this API with handles, which works for both base classes as in the derived class we do not use pointers or indices directly.We checked that the Triangulation with indexed storage can be used in Alpha Wrapping without as only change of code the
typedefof theTDS.Todo
See tracking issue #8969.
Release Management