Merged
Conversation
Collaborator
|
Need to integrate real tests on the routes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a complete REST API for courses and lessons management using FastAPI. The implementation includes four main endpoints: GET /api/courses to retrieve all available courses, GET /api/courses/{id} for specific course details, GET /api/courses/{id}/lessons to fetch course lessons, and GET /api/lessons/{id} for individual lesson details.
The architecture follows a clean layered pattern with API endpoints in courses_api.py, business logic in course_service.py, data access in course_repo.py, and Pydantic schemas in course_schemas.py. The implementation includes comprehensive error handling with 404 responses for missing resources and 400 for invalid inputs, along with full test coverage for all components. All responses are properly validated through Pydantic schemas and the scope is limited to read-only operations as specified.