Skip to content

Push of pad foundation #1651

Open
WojciechBuda00 wants to merge 7 commits intodevelopfrom
Revit_Toolkit-#1650-SupportRevitPadFoundation_Push
Open

Push of pad foundation #1651
WojciechBuda00 wants to merge 7 commits intodevelopfrom
Revit_Toolkit-#1650-SupportRevitPadFoundation_Push

Conversation

@WojciechBuda00
Copy link
Copy Markdown
Contributor

@WojciechBuda00 WojciechBuda00 commented Mar 31, 2026

NOTE: Depends on

Issues addressed by this PR

Closes #1650

Test files

installer

Changelog

Additional comments

@WojciechBuda00 WojciechBuda00 self-assigned this Mar 31, 2026
@WojciechBuda00 WojciechBuda00 added the type:feature New capability or enhancement label Mar 31, 2026
@WojciechBuda00
Copy link
Copy Markdown
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci bot commented Mar 31, 2026

@WojciechBuda00 to confirm, the following actions are now queued:

  • check installer

There are 2 requests in the queue ahead of you.

@WojciechBuda00
Copy link
Copy Markdown
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci bot commented Apr 1, 2026

@WojciechBuda00 to confirm, the following actions are now queued:

  • check installer

There are 12 requests in the queue ahead of you.

@WojciechBuda00
Copy link
Copy Markdown
Contributor Author

@BHoMBot check project-compliance
@BHoMBot check code-compliance

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci bot commented Apr 2, 2026

@WojciechBuda00 to confirm, the following actions are now queued:

  • check project-compliance
  • check code-compliance

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci bot commented Apr 3, 2026

Please be advised that the check with reference 69798898856 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 49 additional annotations waiting, made up of 49 errors and 0 warnings.

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci bot commented Apr 3, 2026

Please be advised that the check with reference 69807979654 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 4 additional annotations waiting, made up of 4 errors and 0 warnings.

@WojciechBuda00
Copy link
Copy Markdown
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci bot commented Apr 3, 2026

@WojciechBuda00 to confirm, the following actions are now queued:

  • check installer

Copy link
Copy Markdown
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still quite some work to do, see my comments. On top of that, I've tested the PR using the foundations pulled from #1646, and have a few comments comments:

  • one element comes out rotated by 90 degrees
  • foundations with nonlinear edges throw nasty errors on push
    Image
  • have not tested, but what will happen with foundations with outlines as non-rectangular polylines?
Image

We also need to catch up on 2 more topics:

  • setting up the families
  • update of foundation dimensions on Update

Comment thread Revit_Core_Engine/Compute/GeneratePadFoundation.cs Outdated
Comment thread Revit_Core_Engine/Compute/GeneratePadFoundation.cs Outdated
Comment thread Revit_Core_Engine/Compute/GeneratePadFoundation.cs Outdated
Comment thread Revit_Core_Engine/Compute/GeneratePadFoundation.cs Outdated
Comment thread Revit_Core_Engine/Compute/GeneratePadFoundation.cs Outdated
Comment thread Revit_Core_Engine/Query/FoundationGeometry.cs Outdated
Comment thread Revit_Core_Engine/Query/FoundationGeometry.cs Outdated
Comment thread Revit_Core_Engine/Query/FoundationGeometry.cs Outdated
Comment thread Revit_Core_Engine/Query/FoundationGeometry.cs Outdated
Comment thread Revit_Core_Engine/Query/FoundationGeometry.cs Outdated
Non-rectangular pad foundations are now supported by using the longest edge direction for rotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for pad foundations - push

2 participants