Conversation
|
@BHoMBot check installer |
|
@WojciechBuda00 to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
|
@BHoMBot check installer |
|
@WojciechBuda00 to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
|
@WojciechBuda00 to confirm, the following actions are now queued:
|
|
Please be advised that the check with reference 69798898856 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 49 additional annotations waiting, made up of 49 errors and 0 warnings. |
|
Please be advised that the check with reference 69807979654 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 4 additional annotations waiting, made up of 4 errors and 0 warnings. |
|
@BHoMBot check installer |
|
@WojciechBuda00 to confirm, the following actions are now queued:
|
pawelbaran
left a comment
There was a problem hiding this comment.
There is still quite some work to do, see my comments. On top of that, I've tested the PR using the foundations pulled from #1646, and have a few comments comments:
- one element comes out rotated by 90 degrees
- foundations with nonlinear edges throw nasty errors on push

- have not tested, but what will happen with foundations with outlines as non-rectangular polylines?
We also need to catch up on 2 more topics:
- setting up the families
- update of foundation dimensions on
Update
Non-rectangular pad foundations are now supported by using the longest edge direction for rotation
NOTE: Depends on
Issues addressed by this PR
Closes #1650
Test files
installer
Changelog
Additional comments