Conversation
… fix existing issues
…x existing issues
|
You can test this PR using the following package version. |
MrJul
approved these changes
Sep 14, 2026
MrJul
left a comment
Member
There was a problem hiding this comment.
Good set of tests!
A small nitpick, otherwise LGTM.
| .Select(r => (Type)r.Key) | ||
| .ToHashSet(); | ||
|
|
||
| Assert.All(templatedControls, c => Assert.Contains(c, defaultControlThemes)); |
Member
There was a problem hiding this comment.
Nit: add an Assert.NotEmpty(templatedControls) before, to make sure the test doesn't pass for the wrong reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Adds a new
Avalonia.Themes.UnitTestsproject that validates the built-in Fluent and Simple themes, and fixes the theme issues these tests found.What is the current behavior?
Before this PR, built-in themes were not covered by any tests. Several types of issues existed unnoticed:
StringCalendarWeekNumberHeaderapparently was still ignored as a resourceWhat is the updated/expected behavior with this PR?
New tests:
ctor(IServiceProvider)and can be reached viaavares:(which we technically always supported).[TemplatePart]is defined in the template.{DynamicResource}references a defined key.How was the solution implemented (if it's not obvious)?
All tests are defined in abstract classes with specific implementations per each theme:
With an idea to later add Fluent2 to the same test project.
Breaking changes
None
Disclamer: This PR was written by hand, without an AI. Code might be better or worse depending on who reads.
But it still was reviewed by Opus.