Skip to content

Update generate-password package#3715

Merged
wojtekn merged 2 commits into
trunkfrom
fix/generate-password-0-2-0
Jun 10, 2026
Merged

Update generate-password package#3715
wojtekn merged 2 commits into
trunkfrom
fix/generate-password-0-2-0

Conversation

@chubes4

@chubes4 chubes4 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • Update @automattic/generate-password from 0.1.0 to 0.2.0 in Studio and @studio/common.
  • Update the lockfile to resolve the published 0.2.0 package.
  • Remove the obsolete apps/studio/patches/@automattic+generate-password+0.1.0.patch patch now that the fix is published upstream.

Testing Instructions

  • npx vitest run tools/common/lib/tests/passwords.test.ts
  • npm run lint -- tools/common/lib/passwords.ts
  • npm run cli:build
  • node apps/cli/dist/cli/main.mjs site create --name "Generate Password 0.2.0 Evidence" --path "/var/folders/lr/c_cmmt7s0592m4njz99v5yb40000gn/T/opencode/studio-generate-password-0-2-0-site" --no-start --skip-browser --skip-log-details

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Inspecting the upstream package-release context, applying the Studio dependency cleanup, and running targeted verification. Chris remains responsible for review and merge.

@chubes4 chubes4 requested a review from wojtekn June 5, 2026 17:06
@wojtekn

wojtekn commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@chubes4 thanks for updating the package.

The change looks good, and it's expected to fail at this point:

notarget No matching version found for @automattic/generate-password@^0.2.0 with a date before 6/3/2026, 9:50:58 AM.

@wojtekn

wojtekn commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

I rerun jobs as they should succeed now.

@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 5c39dbf vs trunk

app-size

Metric trunk 5c39dbf Diff Change
App Size (Mac) 1358.03 MB 1358.04 MB +0.01 MB ⚪ 0.0%

site-editor

Metric trunk 5c39dbf Diff Change
load 1644 ms 1666 ms +22 ms ⚪ 0.0%

site-startup

Metric trunk 5c39dbf Diff Change
siteCreation 9029 ms 9055 ms +26 ms ⚪ 0.0%
siteStartup 4416 ms 4421 ms +5 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@wojtekn wojtekn merged commit bdd10f0 into trunk Jun 10, 2026
11 checks passed
@wojtekn wojtekn deleted the fix/generate-password-0-2-0 branch June 10, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI site creation fails when generating default admin password

3 participants