Update generate-password package#3715
Merged
Merged
Conversation
Contributor
|
@chubes4 thanks for updating the package. The change looks good, and it's expected to fail at this point: |
wojtekn
approved these changes
Jun 5, 2026
Contributor
|
I rerun jobs as they should succeed now. |
Collaborator
📊 Performance Test ResultsComparing 5c39dbf vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
wojtekn
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
@automattic/generate-passwordfrom0.1.0to0.2.0in Studio and@studio/common.0.2.0package.apps/studio/patches/@automattic+generate-password+0.1.0.patchpatch now that the fix is published upstream.Testing Instructions
npx vitest run tools/common/lib/tests/passwords.test.tsnpm run lint -- tools/common/lib/passwords.tsnpm run cli:buildnode apps/cli/dist/cli/main.mjs site create --name "Generate Password 0.2.0 Evidence" --path "/var/folders/lr/c_cmmt7s0592m4njz99v5yb40000gn/T/opencode/studio-generate-password-0-2-0-site" --no-start --skip-browser --skip-log-detailsAI assistance