Skip to content

fix: scss import warning #7528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyangconn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: scss import warning #7528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b2099b
chore(dashboard): 将 Sass @import 迁移到 @use
LIghtJUNction Mar 27, 2026
a7033de
add new import into style.scss
kyangconn Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dashboard/src/scss/components/_VButtons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables' as *;

//
// Light Buttons
//
Expand Down
2 changes: 2 additions & 0 deletions dashboard/src/scss/components/_VCard.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables' as *;

// Outline Card
.v-card--variant-outlined {
border-color: rgba(var(--v-theme-borderLight), 0.36);
Expand Down
2 changes: 2 additions & 0 deletions dashboard/src/scss/components/_VField.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables' as *;

.v-field--variant-outlined .v-field__outline__start.v-locale--is-ltr,
.v-locale--is-ltr .v-field--variant-outlined .v-field__outline__start {
border-radius: $border-radius-root 0 0 $border-radius-root;
Expand Down
2 changes: 2 additions & 0 deletions dashboard/src/scss/components/_VShadow.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables' as *;

.elevation-10 {
box-shadow: $box-shadow !important;
}
2 changes: 2 additions & 0 deletions dashboard/src/scss/components/_VTabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables' as *;

.theme-tab {
&.v-tabs {
.v-tab {
Expand Down
2 changes: 2 additions & 0 deletions dashboard/src/scss/layout/_container.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables' as *;

html {
overflow-y: auto;
}
Expand Down
2 changes: 2 additions & 0 deletions dashboard/src/scss/layout/_sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables' as *;

/*This is for the logo*/
.leftSidebar {
border: 0px;
Expand Down
32 changes: 16 additions & 16 deletions dashboard/src/scss/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
@import './variables';
@import 'vuetify/styles/main.sass';
@import './override';
@import './layout/container';
@import './layout/sidebar';
@use './variables';
@use 'vuetify/styles/main.sass';
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Switching from @import to @use for vuetify/styles/main.sass changes how variable overrides are handled. In Sass modules, variables defined in ./variables (such as $border-radius-root or $color-pack) are no longer automatically available to the Vuetify module. If these variables were intended to customize Vuetify's default styling, you must now use the with configuration syntax or ensure the variables are forwarded correctly. For example: @use 'vuetify/styles/main.sass' with ($border-radius-root: 8px);.

@use './override';
@use './layout/container';
@use './layout/sidebar';

@import './components/VButtons';
@import './components/VCard';
@import './components/VField';
@import './components/VInput';
@import './components/VNavigationDrawer';
@import './components/VShadow';
@import './components/VTextField';
@import './components/VTabs';
@import './components/VScrollbar';
@import './components/CodeBlockDark';
@use './components/VButtons';
@use './components/VCard';
@use './components/VField';
@use './components/VInput';
@use './components/VNavigationDrawer';
@use './components/VShadow';
@use './components/VTextField';
@use './components/VTabs';
@use './components/VScrollbar';
@use './components/CodeBlockDark';

@import './pages/dashboards';
@use './pages/dashboards';
Comment on lines +10 to +18
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The migration to @use appears to be incomplete. While several partials (like VButtons, VCard, and VShadow) were updated in this PR to include @use '../variables' as *;, others imported here—specifically VInput (line 10), VNavigationDrawer (line 11), VTextField (line 13), VScrollbar (line 15), CodeBlockDark (line 16), and dashboards (line 18)—were not included in the patch. If these files reference variables from _variables.scss, the build will fail with 'Undefined variable' errors because @use does not provide a global scope like @import did. Please ensure all partials are updated to explicitly load their dependencies.


html, body {
overscroll-behavior-y: none;
Expand Down
Loading