Skip to content

fix: routing not displayed when session id includes :#7517

Merged
Soulter merged 2 commits intomasterfrom
fix/7515
Apr 13, 2026
Merged

fix: routing not displayed when session id includes :#7517
Soulter merged 2 commits intomasterfrom
fix/7515

Conversation

@Soulter
Copy link
Copy Markdown
Member

@Soulter Soulter commented Apr 13, 2026

fixes: #7515

Modifications / 改动点

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Handle routing table entries whose session IDs may contain colon characters by introducing structured UMOP parsing.

Bug Fixes:

  • Ensure routes are correctly displayed and matched for platforms when UMOP session IDs include colon characters instead of being split incorrectly.

Enhancements:

  • Introduce a reusable UMOP parsing helper and centralize platform matching and field extraction logic based on the parsed structure.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 13, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot bot added the area:webui The bug / feature is about webui(dashboard) of astrbot. label Apr 13, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a parseUmop helper method to centralize the parsing of UMOP strings, replacing manual string splitting in AddNewPlatform.vue. The feedback identifies an optimization opportunity in the route processing loop where parseUmop is called redundantly, and suggests simplifying the normalization logic for messageType and sessionId using logical OR operators.

@Soulter Soulter merged commit abd11d5 into master Apr 13, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webui The bug / feature is about webui(dashboard) of astrbot. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 机器人路由配置会话ID如果包含冒号会导致不显示

1 participant