Skip to content

Fix init warning tests and bump package version to 1.5.0#2099

Draft
Copilot wants to merge 3 commits intomainfrom
copilot/update-version-to-v1-5-0
Draft

Fix init warning tests and bump package version to 1.5.0#2099
Copilot wants to merge 3 commits intomainfrom
copilot/update-version-to-v1-5-0

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 19, 2026

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

This updates the follow-up requested in the review thread: the spectrafit init tests now contain the package lifecycle warning instead of leaking it at import time, and the package version is advanced to 1.5.0 across the canonical version surfaces.

  • Warning-safe init tests

    • spectrafit/test/test_init.py no longer imports spectrafit outside warnings.catch_warnings(...) in tests that exercise import-time warnings.
    • The version test now reloads the package under a FutureWarning ignore filter and reads module.__version__, keeping the assertion focused on version parity.
  • Version bump

    • Updated package metadata in pyproject.toml
    • Updated runtime version in spectrafit/__init__.py
    • Existing version assertions continue to validate the new release value through __version__
  • Representative change

    with warnings.catch_warnings():
        warnings.simplefilter("ignore", FutureWarning)
        module = reload_spectrafit()
    
    assert module.__version__ == pkg_version("spectrafit")

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com bot commented Mar 19, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  pyproject.toml Unsupported file format
  spectrafit/__init__.py  0% smaller
  spectrafit/test/test_init.py  0% smaller

Co-authored-by: Anselmoo <13209783+Anselmoo@users.noreply.github.com>
Co-authored-by: Anselmoo <13209783+Anselmoo@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

Copilot AI changed the title [WIP] Apply review comments and update version number to v1.5.0 Fix init warning tests and bump package version to 1.5.0 Mar 19, 2026
Copilot AI requested a review from Anselmoo March 19, 2026 22:44
@stale
Copy link
Copy Markdown

stale bot commented Apr 3, 2026

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants