Skip to content

[PWGCF] create a minimum container for di-hadron correlations#16979

Merged
wenyaCern merged 7 commits into
AliceO2Group:masterfrom
Luzhiyongg:master
Jul 9, 2026
Merged

[PWGCF] create a minimum container for di-hadron correlations#16979
wenyaCern merged 7 commits into
AliceO2Group:masterfrom
Luzhiyongg:master

Conversation

@Luzhiyongg

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 18 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title create a minimum encapsulated container for di-hadron correlations [PWGCF] create a minimum encapsulated container for di-hadron correlations Jul 9, 2026
[PWGCF] Please consider the following formatting changes to AliceO2Group#16979
@alibuild

alibuild commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 2315f8e at 2026-07-09 10:13:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 17 errors and 0 warnings.'
Found 17 errors and 0 warnings.
++ [[ 17 -gt 0 ]]
++ cat /sw/BUILD/c484be341345d2ead273fe13a1159aa4cae0d653/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:19:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:24:1: error: included header TCanvas.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:26:1: error: included header TF1.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:30:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:31:1: error: included header TMathBase.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:48:1: error: constructor does not initialize these fields: nCorrStep [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:48:42: error: initializer for base class 'TNamed' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:57:44: error: no header providing "uint8_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:66:40: error: local copy 'pairAxis' of the variable 'correlationAxis' is never modified; consider avoiding the copy [performance-unnecessary-copy-initialization,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:69:8: error: no header providing "uint" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:112:3: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:112:31: error: do not use C-style cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-cstyle-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:157:3: error: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:166:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.h:46:9: error: function 'DihadronContainer::DihadronContainer' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.h:46:127: error: no header providing "uint8_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.h:47:17: error: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 17 -gt 0 ]]
++ exit 1
--

Full log here.

@Luzhiyongg Luzhiyongg changed the title [PWGCF] create a minimum encapsulated container for di-hadron correlations [PWGCF] create a minimum container for di-hadron correlations Jul 9, 2026
@alibuild

alibuild commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for cab2313 at 2026-07-09 10:22:

++ set -euo pipefail
++ [[ -d /sw/slc9_x86-64/Clang/v20.1.7-20 ]]
+++ realpath /sw/BUILD/0f4b764d3334cf443a65dc1ed00641936b9b1d97/O2Physics-code-check/../../O2Physics-latest/O2Physics
++ O2PHYSICS_BUILDDIR=/sw/BUILD/4ebcec2ee56667a72cd9c1c0dafa8b7f62963204/O2Physics
++ cp /sw/BUILD/4ebcec2ee56667a72cd9c1c0dafa8b7f62963204/O2Physics/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2PHYSICS_SRC=/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0
++ pushd /sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0
/sw/SPECS/slc9_x86-64/O2Physics-code-check/1.0-local84/O2Physics-code-check.sh: line 16: pushd: /sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0: No such file or directory

Full log here.

@alibuild

alibuild commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 25d64f0 at 2026-07-09 11:08:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 0 warnings.'
Found 5 errors and 0 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/41ab110601eb49cf3fda138e7d65fd7cfe5c8790/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:61:8: error: no header providing "uint" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:76:3: error: Call to virtual method 'DihadronContainer::Copy' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:76:3: error: redundant explicit casting to the same type 'const DihadronContainer' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.cxx:94:5: error: redundant explicit casting to the same type 'const DihadronContainer' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/DihadronContainer.h:48:11: error: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

Please consider the following formatting changes to AliceO2Group#16979
@wenyaCern wenyaCern merged commit abd74fe into AliceO2Group:master Jul 9, 2026
14 of 15 checks passed
mcoquet642 pushed a commit to AliceMCH/O2Physics that referenced this pull request Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants