Skip to content

[PWGLF] updated table producer with new recentering procedure to check v1#16934

Merged
prottayCMT merged 2 commits into
AliceO2Group:masterfrom
prottayCMT:master
Jul 6, 2026
Merged

[PWGLF] updated table producer with new recentering procedure to check v1#16934
prottayCMT merged 2 commits into
AliceO2Group:masterfrom
prottayCMT:master

Conversation

@prottayCMT

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwglf label Jul 6, 2026
@prottayCMT prottayCMT changed the title updated code with new recentering procedure to check v1 updated table producer with new recentering procedure to check v1 Jul 6, 2026
@github-actions github-actions Bot changed the title updated table producer with new recentering procedure to check v1 [PWGLF] updated code with new recentering procedure to check v1 Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 51 errors, ⚠️ 70 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title [PWGLF] updated code with new recentering procedure to check v1 [PWGLF] updated table producer with new recentering procedure to check v1 Jul 6, 2026
@prottayCMT prottayCMT enabled auto-merge (squash) July 6, 2026 13:45
@alibuild

alibuild commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 20d6c54 at 2026-07-06 16:01:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 15 errors and 4 warnings.'
Found 15 errors and 4 warnings.
++ [[ 15 -gt 0 ]]
++ cat /sw/BUILD/3d12505c551a10dbf77abab4ef5669a60427a1e5/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Common/spvector.cxx:62:8: error: constructor does not initialize these fields: ccdb, hrecentereSpA, hrecenterecentSpA, hrecenterevxSpA, hrecenterevySpA, hrecenterevzSpA [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:432:14: error: no header providing "TH3F" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:554:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:571:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:576:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:580:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:584:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:698:22: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:761:17: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:762:17: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:781:13: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:797:13: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:989:13: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:989:25: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:993:35: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/3d12505c551a10dbf77abab4ef5669a60427a1e5/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Common/spvector.cxx:816:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/spvector.cxx:818:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/spvector.cxx:825:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/spvector.cxx:827:13: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 15 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d90dfab at 2026-07-06 16:16:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 15 errors and 4 warnings.'
Found 15 errors and 4 warnings.
++ [[ 15 -gt 0 ]]
++ cat /sw/BUILD/2995b828be8d3a2ec5b67ae1bcbd513cc34b7799/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Common/spvector.cxx:62:8: error: constructor does not initialize these fields: ccdb, gainprofile, gainprofilevxy, hrecentereSpA, hrecenterecentSpA, hrecenterevxSpA, hrecenterevySpA, hrecenterevzSpA, shiftprofileA, shiftprofileC [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:432:14: error: no header providing "TH3F" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:554:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:571:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:576:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:580:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:584:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:698:22: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:760:17: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:761:17: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:780:13: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:796:13: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:988:13: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:988:25: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Common/spvector.cxx:992:35: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/2995b828be8d3a2ec5b67ae1bcbd513cc34b7799/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Common/spvector.cxx:815:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/spvector.cxx:817:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/spvector.cxx:824:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/spvector.cxx:826:13: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 15 -gt 0 ]]
++ exit 1
--

Full log here.

@prottayCMT prottayCMT merged commit a980fad into AliceO2Group:master Jul 6, 2026
11 of 15 checks passed
mcoquet642 pushed a commit to AliceMCH/O2Physics that referenced this pull request Jul 9, 2026
…k v1 (AliceO2Group#16934)

Co-authored-by: Prottay Das <prottay@alipap1.cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants