[Common] Add zdc-extra-table-reader task by udmitrie · Pull Request #16028 · AliceO2Group/O2Physics

udmitrie · 2026-04-29T16:49:21Z

zdc-extra-table-reader is needed to read AOD/ZDCEXTRA derived data and proceed with multi-step calibration (Q-vectors recentering) of ZDC data

zdc-extra-table-reader is needed to read AOD/ZDCEXTRA derived data and proceed with multistep calibration (Q-vectors recentering) of ZDC data

github-actions · 2026-04-29T16:49:45Z

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

Refactor logging and constants in zdcExtraTableReader. Replaced std::cerr logging with LOGF for error handling and updated constant names for consistency.

Add check number of fired towers with isZN*SpDeterminable (to reconstruct Q-vector at least 2 fired towers needed); Replace FindBin with FindFixBin; update variables.

Please consider the following formatting changes to AliceO2Group#16028

udmitrie · 2026-04-29T19:50:21Z

Dear code owners,
Please take a look at this pull request.

There are no O2 linter errors connected to my changes.
The job is failing due to workflow naming convention violations in old tasks in Common/Tasks/CMakeLists.txt.

Fix code formatting

udmitrie · 2026-06-05T16:04:13Z

Dear code owners,

Please note that the failed CI checks are not related to my zdc-extra-table-reader task:

o2linter is failing due to naming errors in CMakeLists.txt for unrelated tasks (e.g., propagatorQa, cpvQa);
MegaLinter is failing due to the osv-scanner error (according to the recent announcement in the O2 Analysis Announcements channel, this is a known side effect of the linter upgrade)

vkucera · 2026-06-05T16:30:05Z

@udmitrie Since you are adding a new file, please fix the warnings as well.

Replaced individual Qx and Qy axis configurables with a shared ConfigurableAxis

udmitrie · 2026-06-09T10:57:34Z

Dear @vkucera, could you please confirm that you have no further comments? Otherwise, is there anything else I need to fix?

alibuild · 2026-06-09T16:57:47Z

Error while checking build/O2Physics/o2 for bf83055 at 2026-06-12 07:14:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

Initialize histogram pointers as nullptr. Remove redundant comments and logs.

Please consider the following formatting changes to AliceO2Group#16028

alibuild · 2026-06-19T13:03:51Z

Error while checking build/O2Physics/staging for 81f104a at 2026-06-29 09:51:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-06-30T15:08:58Z

Error while checking build/O2Physics/o2 for 81f104a at 2026-07-02 10:48:

## sw/BUILD/O2Physics-latest/log
2026-07-02T10:47:46.254+0200 [31537:140523825454720] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-02T10:47:46.262+0200 [31537:140523825454720] [executioncontext.cpp:739] [ERROR] Failed to download output blob bb9c1fede965f95b5c3d877ef7a5a61dd2a2a095c9f8b444133dcb5732a54a79: 14: Socket closed
2026-07-02T10:47:46.254+0200 [31384:140686098955904] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.263+0200 [31384:140686098955904] [executioncontext.cpp:739] [ERROR] Failed to download output blob 0e75c682605dd67587256eb3f4ec29f6d81f3551b9bdc9e3e7dcba3141f6dee7: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31278:140580006227584] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-02T10:47:46.263+0200 [31278:140580006227584] [executioncontext.cpp:739] [ERROR] Failed to download output blob d9cae5cbc92bca569eb5694fd61840695252e0d66ee590d2bf8fe1e40a6fa757: 14: Socket closed
2026-07-02T10:47:46.254+0200 [31340:140362198347392] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.263+0200 [31340:140362198347392] [executioncontext.cpp:739] [ERROR] Failed to download output blob 67e3f79142c641cbc6900732dac9f09ccaa8d822f841166966f5cb21ff0c4d95: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31258:139928168525440] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-02T10:47:46.264+0200 [31258:139928168525440] [executioncontext.cpp:739] [ERROR] Failed to download output blob ca7db0a975de6f1271b3724ad833bc969492ddc4cf7027d999b102a3b5e24c4e: 14: Socket closed
2026-07-02T10:47:46.254+0200 [31257:140576581250688] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.264+0200 [31257:140576581250688] [executioncontext.cpp:739] [ERROR] Failed to download output blob 1736d3d01593e5b85ba82dbe9555336f48dbafa60952ef1abc790b50474f0f8b: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31433:139772600807040] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-02T10:47:46.265+0200 [31433:139772600807040] [executioncontext.cpp:739] [ERROR] Failed to download output blob a169847ffa7ea59d6d12f33ad94e99861ed3240d30e1224556d4b3a3a8fe34ef: 14: Socket closed
2026-07-02T10:47:46.254+0200 [31362:139788454526592] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.265+0200 [31362:139788454526592] [executioncontext.cpp:739] [ERROR] Failed to download output blob a436d0b5afb54a416af6d5703c4454f0974982e55a74028254658c5496688bcf: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31037:140019339067008] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-02T10:47:46.266+0200 [31037:140019339067008] [executioncontext.cpp:739] [ERROR] Failed to download output blob c1b2aadd859cfab93e04c7de6739d8529bf07d4fa36d15f584ecff4341e8b001: 14: Socket closed
2026-07-02T10:47:46.254+0200 [31125:139653962514048] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.266+0200 [31125:139653962514048] [executioncontext.cpp:739] [ERROR] Failed to download output blob b2fdb91455b4575a5d38ca1325cbfb81f8f15acdebf1f8441eee462ccd31f16f: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [30990:140573737791104] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.267+0200 [30990:140573737791104] [executioncontext.cpp:739] [ERROR] Failed to download output blob bf3044054ff4786957a3437097eb700b56e3dd6328547152ec7a8f13e830b603: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31209:140332734516864] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.266+0200 [31209:140332734516864] [executioncontext.cpp:739] [ERROR] Failed to download output blob 1740bb4e50b6feda7eb9c5bda77e301a347283aa1316f4e1d3e725cb17e6bb24: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31103:139673862094464] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.266+0200 [31103:139673862094464] [executioncontext.cpp:739] [ERROR] Failed to download output blob 7803931b4d3295a84cf177c364622e8f3f3f621dc580913586e72b85ef49d0eb: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31127:140594675302016] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.267+0200 [31127:140594675302016] [executioncontext.cpp:739] [ERROR] Failed to download output blob d01b33643ba09ab70dcc5324c26bc2273753c0a4fea2cf85b93df98e92ebc2ea: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31013:140418625613440] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.267+0200 [31013:140418625613440] [executioncontext.cpp:739] [ERROR] Failed to download output blob cbe3772e56389fe62aea86d2e8639d78471540786187fa35a84196952cf8885c: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31035:139693185281664] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.267+0200 [31035:139693185281664] [executioncontext.cpp:739] [ERROR] Failed to download output blob b1c43f5da207dd2aad23a624248705409988da215e509a07c38b0b913deebb69: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31124:140244792397440] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.266+0200 [31124:140244792397440] [executioncontext.cpp:739] [ERROR] Failed to download output blob 25206809b9cf860379b864af38f2d8399ef1c72014fe4b4e958b9c0f0cba70db: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31235:139936519614080] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.266+0200 [31235:139936519614080] [executioncontext.cpp:739] [ERROR] Failed to download output blob ca6195e26dd3b62272d8cff998c5e6257a7ef7cbd0108c8b21a0b3300435b09d: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31320:140627861503616] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.265+0200 [31320:140627861503616] [executioncontext.cpp:739] [ERROR] Failed to download output blob 6d59686702f350f9d27dcc60f85c077ecc8e015667070dcf1bc3dc210e28ea36: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [30927:140364375101056] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.268+0200 [30927:140364375101056] [executioncontext.cpp:739] [ERROR] Failed to download output blob 6b75742d0dd26ab8fab78fab863e7a43b1e83809eeaee30d0a9f2eec0b7a7521: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31126:139741140946560] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.266+0200 [31126:139741140946560] [executioncontext.cpp:739] [ERROR] Failed to download output blob 27c37b738cd5c8694c7d080ef167d70d635414b7dcf835265691e525fbd04e95: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [30930:139857308884608] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.268+0200 [30930:139857308884608] [executioncontext.cpp:739] [ERROR] Failed to download output blob 4d3a8c361c62366f047bd8c7bcd11b022f431a94c8f764cb1d271c4ac7c6c164: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [31034:140576221113984] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.267+0200 [31034:140576221113984] [executioncontext.cpp:739] [ERROR] Failed to download output blob 5199ca55bec2e0e83c940cf40adb438c9d66caa5037911a432273cda6a8ccc4f: 14: recvmsg:Connection reset by peer
2026-07-02T10:47:46.254+0200 [30929:140148936838784] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-07-02T10:47:46.268+0200 [30929:140148936838784] [executioncontext.cpp:739] [ERROR] Failed to download output blob 3e4e7b01324e0830277cfc99c75fedf3dc159efb5b877dae9be55c3bb4aabc41: 14: recvmsg:Connection reset by peer
[0 more errors; see full log]

Full log here.

udmitrie · 2026-07-01T08:45:05Z

Dear @vkucera, please let me know if there are any other stoppers from your side before merging this task to O2Physics?

vkucera · 2026-07-01T08:54:14Z

Dear @vkucera, please let me know if there are any other stoppers from your side before merging this task to O2Physics?

Hi @udmitrie , it looks good to me. I have no further comments. Thank you.

alibuild · 2026-07-01T18:59:31Z

Error while checking build/O2Physics/code-check for 81f104a at 2026-07-02 00:33:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 179 errors and 5 warnings.'
Found 179 errors and 5 warnings.
++ [[ 179 -gt 0 ]]
++ cat /sw/BUILD/7bfd0e56c5b208e5498105822ce5189ede31b9a7/O2Physics-code-check/errors.txt
Common/Tasks/zdcExtraTableReader.cxx:16:1: error: included header EventSelectionParams.h is not used directly [misc-include-cleaner,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:18:1: error: included header Centrality.h is not used directly [misc-include-cleaner,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:19:1: error: included header EventSelection.h is not used directly [misc-include-cleaner,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:23:1: error: included header CcdbApi.h is not used directly [misc-include-cleaner,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:32:1: error: included header OutputObjHeader.h is not used directly [misc-include-cleaner,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:54:31: error: variable 'gEventCounter' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:55:31: error: variable 'gCentroidZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:56:31: error: variable 'gCentroidZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:57:31: error: variable 'gPmcZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:58:31: error: variable 'gPm1ZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:59:31: error: variable 'gPm2ZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:60:31: error: variable 'gPm3ZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:61:31: error: variable 'gPm4ZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:62:31: error: variable 'gSumZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:63:31: error: variable 'gPmcZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:64:31: error: variable 'gPm1ZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:65:31: error: variable 'gPm2ZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:66:31: error: variable 'gPm3ZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:67:31: error: variable 'gPm4ZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:68:31: error: variable 'gSumZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:69:31: error: variable 'gQxVsCentZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:70:31: error: variable 'gQyVsCentZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:71:31: error: variable 'gQxVsVxZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:72:31: error: variable 'gQyVsVxZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:73:31: error: variable 'gQxVsVyZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:74:31: error: variable 'gQyVsVyZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:75:31: error: variable 'gQxVsVzZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:76:31: error: variable 'gQyVsVzZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:77:31: error: variable 'gQxVsCentZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:78:31: error: variable 'gQyVsCentZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:79:31: error: variable 'gQxVsVxZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:80:31: error: variable 'gQyVsVxZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:81:31: error: variable 'gQxVsVyZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:82:31: error: variable 'gQyVsVyZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:83:31: error: variable 'gQxVsVzZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:84:31: error: variable 'gQyVsVzZNC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:85:31: error: variable 'gQxQyVsCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:86:31: error: variable 'gQyQxVsCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:87:31: error: variable 'gQxQxVsCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:88:31: error: variable 'gQyQyVsCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:90:31: error: variable 'gQx5DZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/Tasks/zdcExtraTableReader.cxx:91:31: error: variable 'gQy5DZNA' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Fix O2Physics-code-check errors

Please consider the following formatting changes to AliceO2Group#16028

alibuild · 2026-07-02T09:17:03Z

Error while checking build/O2Physics/code-check for e1454a7 at 2026-07-03 08:19:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

udmitrie added 2 commits April 29, 2026 18:47

Add zdc-extra-table-reader task

e4cb846

zdc-extra-table-reader is needed to read AOD/ZDCEXTRA derived data and proceed with multistep calibration (Q-vectors recentering) of ZDC data

Add zdc-extra-table-reader workflow to CMakeLists

2faab54

github-actions Bot added the common label Apr 29, 2026

Fix o2 linter errors

7aed372

Refactor logging and constants in zdcExtraTableReader. Replaced std::cerr logging with LOGF for error handling and updated constant names for consistency.

udmitrie marked this pull request as ready for review April 29, 2026 17:05

udmitrie requested review from a team, alibuild, ddobrigk, dsekihat, iarsene, jgrosseo and ktf as code owners April 29, 2026 17:05

udmitrie marked this pull request as draft April 29, 2026 18:21

Update zdc-extra-table-reader

a36b0b5

Add check number of fired towers with isZN*SpDeterminable (to reconstruct Q-vector at least 2 fired towers needed); Replace FindBin with FindFixBin; update variables.

alibuild mentioned this pull request Apr 29, 2026

Please consider the following formatting changes to #16028 udmitrie/O2Physics#8

Merged

udmitrie and others added 3 commits April 29, 2026 21:44

Replace magic number with constexpr for QvectorMaxValue

1996404

Please consider the following formatting changes

23e48e5

Merge pull request #8 from alibuild/alibot-cleanup-16028

5397abb

Please consider the following formatting changes to AliceO2Group#16028

udmitrie marked this pull request as ready for review April 29, 2026 19:49

vkucera reviewed May 6, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

vkucera reviewed May 6, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

vkucera reviewed May 6, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

vkucera reviewed May 6, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

vkucera reviewed May 6, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

vkucera reviewed May 6, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

vkucera reviewed May 6, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

vkucera reviewed May 6, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx

vkucera reviewed May 6, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

alibuild mentioned this pull request Jun 5, 2026

Please consider the following formatting changes to #16028 udmitrie/O2Physics#11

Closed

Fix formatting

368c4aa

Fix code formatting

udmitrie added 2 commits June 5, 2026 18:43

Replace TMath functions with std namespace equivalents

d83ac12

Add QxQy ConfigurableAxis

bf83055

Replaced individual Qx and Qy axis configurables with a shared ConfigurableAxis

vkucera reviewed Jun 9, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

vkucera reviewed Jun 9, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

vkucera reviewed Jun 9, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

vkucera reviewed Jun 9, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

vkucera reviewed Jun 18, 2026

View reviewed changes

Comment thread Common/Tasks/zdcExtraTableReader.cxx Outdated

udmitrie and others added 2 commits June 18, 2026 15:48

Initialize histogram pointers and remove redundant comments

d44df10

Initialize histogram pointers as nullptr. Remove redundant comments and logs.

Please consider the following formatting changes

a448eaf

alibuild mentioned this pull request Jun 18, 2026

Please consider the following formatting changes to #16028 udmitrie/O2Physics#12

Merged

Merge pull request #12 from alibuild/alibot-cleanup-16028

81f104a

Please consider the following formatting changes to AliceO2Group#16028

udmitrie and others added 2 commits July 2, 2026 10:45

Refactor zdcExtraTableReader

872404e

Fix O2Physics-code-check errors

Please consider the following formatting changes

3cb7006

alibuild mentioned this pull request Jul 2, 2026

Please consider the following formatting changes to #16028 udmitrie/O2Physics#15

Merged

Merge pull request #15 from alibuild/alibot-cleanup-16028

e1454a7

Please consider the following formatting changes to AliceO2Group#16028

dsekihat approved these changes Jul 3, 2026

View reviewed changes

dsekihat merged commit c764bec into AliceO2Group:master Jul 3, 2026
12 of 15 checks passed

mcoquet642 pushed a commit to AliceMCH/O2Physics that referenced this pull request Jul 9, 2026

[Common] Add zdc-extra-table-reader task (AliceO2Group#16028)

587806b

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

Uh oh!

Conversation

udmitrie commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

udmitrie commented Apr 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

udmitrie commented Jun 5, 2026

Uh oh!

vkucera commented Jun 5, 2026

Uh oh!

udmitrie commented Jun 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

udmitrie commented Jul 1, 2026

Uh oh!

vkucera commented Jul 1, 2026

Uh oh!

alibuild commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Apr 29, 2026 •

edited

Loading

alibuild commented Jun 9, 2026 •

edited

Loading

alibuild commented Jun 19, 2026 •

edited

Loading

alibuild commented Jun 30, 2026 •

edited

Loading

alibuild commented Jul 1, 2026 •

edited

Loading

alibuild commented Jul 2, 2026 •

edited

Loading