setup eslint and prettier#26
Open
yoshikinoko wants to merge 2 commits into
Open
Conversation
Merged
Contributor
|
@dkstevekwak , any concerns with the eslint configuration here? If not, I'm ok w/ merging |
# Conflicts: # lib/validate.js # package-lock.json # package.json
alexandrtovmach
suggested changes
Jun 9, 2020
alexandrtovmach
left a comment
alexandrtovmach
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! Looks so far so good 👍
I left a few thoughts
| @@ -0,0 +1,11 @@ | |||
| root = true | |||
Contributor
There was a problem hiding this comment.
this file should be ignored by .gitignore
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "lint": "eslint --fix lib && eslint --fix commands", | ||
| "precommit": "lint-staged" |
Contributor
There was a problem hiding this comment.
I can't find config for lint-staged. It should trigger lint for staged files, am I wrong?
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "lint": "eslint --fix lib && eslint --fix commands", |
Contributor
There was a problem hiding this comment.
lintscript should only validate code, not modify- list of folders to lint can be passed one-by-one
Suggested change
| "lint": "eslint --fix lib && eslint --fix commands", | |
| "lint": "eslint lib/** commands/**", | |
| "lint:fix": "eslint --fix lib/** commands/**", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup eslint and prettier #25