Fix issue with the "Resize Window to Fit" (w) command#731
Merged
cedrik-fuoco-adsk merged 4 commits intoAcademySoftwareFoundation:mainfrom Apr 3, 2025
Merged
Conversation
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
eloisebrosseau
approved these changes
Mar 31, 2025
cedrik-fuoco-adsk
merged commit b60f4ec
into
AcademySoftwareFoundation:main
10 checks passed
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 8, 2025
…eFoundation#731) ### Fix issue with the "Resize Window to Fit" (w) command ### Linked issues n/a ### Summarize your change. Remove a call to resizeFit when calling the method triggered by the `w` shortcut. ### Describe the reason for the change. The call to `resizeFit()` was introduced by AcademySoftwareFoundation#194 in July 2023. After removing the call to `resizeFit()`, it does not seem to break what the PR AcademySoftwareFoundation#194 was fixing and it fixes the `w` shortcut. In anycase, the `resizeFit()` should not be called `fitWindowToImage` because they have different purpose and behaviors. ### Describe what you have tested and on which operating system. Rocky Linux 8 ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. When opening RV and the media I used to test:  This is **BEFORE** the fix:  This is **AFTER** the fix:  Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 8, 2025
…eFoundation#731) ### Fix issue with the "Resize Window to Fit" (w) command ### Linked issues n/a ### Summarize your change. Remove a call to resizeFit when calling the method triggered by the `w` shortcut. ### Describe the reason for the change. The call to `resizeFit()` was introduced by AcademySoftwareFoundation#194 in July 2023. After removing the call to `resizeFit()`, it does not seem to break what the PR AcademySoftwareFoundation#194 was fixing and it fixes the `w` shortcut. In anycase, the `resizeFit()` should not be called `fitWindowToImage` because they have different purpose and behaviors. ### Describe what you have tested and on which operating system. Rocky Linux 8 ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. When opening RV and the media I used to test:  This is **BEFORE** the fix:  This is **AFTER** the fix:  Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
richardssam
pushed a commit
to richardssam/OpenRV
that referenced
this pull request
Jun 17, 2025
…eFoundation#731) ### Fix issue with the "Resize Window to Fit" (w) command ### Linked issues n/a ### Summarize your change. Remove a call to resizeFit when calling the method triggered by the `w` shortcut. ### Describe the reason for the change. The call to `resizeFit()` was introduced by AcademySoftwareFoundation#194 in July 2023. After removing the call to `resizeFit()`, it does not seem to break what the PR AcademySoftwareFoundation#194 was fixing and it fixes the `w` shortcut. In anycase, the `resizeFit()` should not be called `fitWindowToImage` because they have different purpose and behaviors. ### Describe what you have tested and on which operating system. Rocky Linux 8 ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. When opening RV and the media I used to test:  This is **BEFORE** the fix:  This is **AFTER** the fix:  Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
richardssam
pushed a commit
to richardssam/OpenRV
that referenced
this pull request
Jun 17, 2025
…eFoundation#731) ### Fix issue with the "Resize Window to Fit" (w) command ### Linked issues n/a ### Summarize your change. Remove a call to resizeFit when calling the method triggered by the `w` shortcut. ### Describe the reason for the change. The call to `resizeFit()` was introduced by AcademySoftwareFoundation#194 in July 2023. After removing the call to `resizeFit()`, it does not seem to break what the PR AcademySoftwareFoundation#194 was fixing and it fixes the `w` shortcut. In anycase, the `resizeFit()` should not be called `fitWindowToImage` because they have different purpose and behaviors. ### Describe what you have tested and on which operating system. Rocky Linux 8 ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. When opening RV and the media I used to test:  This is **BEFORE** the fix:  This is **AFTER** the fix:  Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with the "Resize Window to Fit" (w) command
Linked issues
n/a
Summarize your change.
Remove a call to resizeFit when calling the method triggered by the
wshortcut.Describe the reason for the change.
The call to
resizeFit()was introduced by #194 in July 2023. After removing the call toresizeFit(), it does not seem to break what the PR #194 was fixing and it fixes thewshortcut. In anycase, theresizeFit()should not be calledfitWindowToImagebecause they have different purpose and behaviors.Describe what you have tested and on which operating system.
Rocky Linux 8
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.
When opening RV and the media I used to test:
This is BEFORE the fix:
This is AFTER the fix:
