Remove show property from annotation hook#727
Merged
eloisebrosseau merged 2 commits intoAcademySoftwareFoundation:mainfrom Apr 1, 2025
Merged
Remove show property from annotation hook#727eloisebrosseau merged 2 commits intoAcademySoftwareFoundation:mainfrom
eloisebrosseau merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
cedrik-fuoco-adsk
approved these changes
Mar 24, 2025
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
eloisebrosseau
force-pushed
the
show-annotations
branch
from
0de75df to
71c6fd9
Compare
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
eloisebrosseau
merged commit 7bb75bc
into
AcademySoftwareFoundation:main
10 checks passed
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 8, 2025
) The `visible` layer attribute is not used anymore to indicate if annotations should be shown or not. Therefore, the `show` attribute of the RVPaint node should not be set with that attribute value. Show and hide annotation actions are now only being handled in the Live Review plugin. The required changes were made in this [PR](https://git.autodesk.com/media-and-entertainment/rv/pull/336). Since Creative Review is now sending an event as part of the `PLAYBACK_SETTINGS` command, we should not use the `visible` attribute of the OTIO Timeline to know if the annotations should be shown or not. This change was tested on macOS in a Live Review session between RV and the Creative Review prototype. --------- Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 8, 2025
) The `visible` layer attribute is not used anymore to indicate if annotations should be shown or not. Therefore, the `show` attribute of the RVPaint node should not be set with that attribute value. Show and hide annotation actions are now only being handled in the Live Review plugin. The required changes were made in this [PR](https://git.autodesk.com/media-and-entertainment/rv/pull/336). Since Creative Review is now sending an event as part of the `PLAYBACK_SETTINGS` command, we should not use the `visible` attribute of the OTIO Timeline to know if the annotations should be shown or not. This change was tested on macOS in a Live Review session between RV and the Creative Review prototype. --------- Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com> Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
richardssam
pushed a commit
to richardssam/OpenRV
that referenced
this pull request
Jun 17, 2025
) ### Remove show property from annotation hook ### Summarize your change. The `visible` layer attribute is not used anymore to indicate if annotations should be shown or not. Therefore, the `show` attribute of the RVPaint node should not be set with that attribute value. Show and hide annotation actions are now only being handled in the Live Review plugin. The required changes were made in this [PR](https://git.autodesk.com/media-and-entertainment/rv/pull/336). ### Describe the reason for the change. Since Creative Review is now sending an event as part of the `PLAYBACK_SETTINGS` command, we should not use the `visible` attribute of the OTIO Timeline to know if the annotations should be shown or not. ### Describe what you have tested and on which operating system. This change was tested on macOS in a Live Review session between RV and the Creative Review prototype. --------- Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com> Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
richardssam
pushed a commit
to richardssam/OpenRV
that referenced
this pull request
Jun 17, 2025
) ### Remove show property from annotation hook ### Summarize your change. The `visible` layer attribute is not used anymore to indicate if annotations should be shown or not. Therefore, the `show` attribute of the RVPaint node should not be set with that attribute value. Show and hide annotation actions are now only being handled in the Live Review plugin. The required changes were made in this [PR](https://git.autodesk.com/media-and-entertainment/rv/pull/336). ### Describe the reason for the change. Since Creative Review is now sending an event as part of the `PLAYBACK_SETTINGS` command, we should not use the `visible` attribute of the OTIO Timeline to know if the annotations should be shown or not. ### Describe what you have tested and on which operating system. This change was tested on macOS in a Live Review session between RV and the Creative Review prototype. --------- Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com> Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove show property from annotation hook
Summarize your change.
The
visiblelayer attribute is not used anymore to indicate if annotations should be shown or not. Therefore, theshowattribute of the RVPaint node should not be set with that attribute value. Show and hide annotation actions are now only being handled in the Live Review plugin. The required changes were made in this PR.Describe the reason for the change.
Since Creative Review is now sending an event as part of the
PLAYBACK_SETTINGScommand, we should not use thevisibleattribute of the OTIO Timeline to know if the annotations should be shown or not.Describe what you have tested and on which operating system.
This change was tested on macOS in a Live Review session between RV and the Creative Review prototype.