Skip to content

build: Fix various with the debug build on Windows#1222

Merged
cedrik-fuoco-adsk merged 3 commits intoAcademySoftwareFoundation:mainfrom
cedrik-fuoco-adsk:various-windows-debug-fix
Apr 10, 2026
Merged

build: Fix various with the debug build on Windows#1222
cedrik-fuoco-adsk merged 3 commits intoAcademySoftwareFoundation:mainfrom
cedrik-fuoco-adsk:various-windows-debug-fix

Conversation

@cedrik-fuoco-adsk
Copy link
Copy Markdown
Contributor

Fix various with the debug build on Windows

Linked issues

n/a

Summarize your change.

Fix several issues that prevented OpenRV from building and running correctly in Debug configuration on Windows.

Describe the reason for the change.

  • Windows debug Python looks for extension modules with a _d suffix (e.g. pyimgui_d.pyd).
  • Additionally, the CMake Python::Python imported target was using a single IMPORTED_IMPLIB that didn't account for multi-config generators (Visual Studio), causing LNK1104 linker errors when switching between Debug and Release.
  • OpenTimelineIO had a crash on Windows debug builds caused by a pybind11 bug.

Temporarily points opentimelineio to a personal fork (cedrik-fuoco-adsk/OpenTimelineIO@fix-windows-debug-crash) to fix a pybind11 crash on Windows debug builds. This should be reverted once the upstream OTIO PR is merged, and use the main branch of OTIO. Once this is merged and OTIO releases a new version, we can go back to using tagged version.

Describe what you have tested and on which operating system.

  • Windows 11, Debug build of OpenRV

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
@cedrik-fuoco-adsk cedrik-fuoco-adsk force-pushed the various-windows-debug-fix branch from ccb45fc to 8b8bebf Compare April 9, 2026 15:53
Copy link
Copy Markdown
Contributor

@bernie-laberge bernie-laberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cedrik-fuoco-adsk cedrik-fuoco-adsk merged commit 2889e3c into AcademySoftwareFoundation:main Apr 10, 2026
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants