Fix OSL definitions of matrix extract#2849
Merged
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom Apr 1, 2026
Merged
Fix OSL definitions of matrix extract#2849jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
This changelist fixes a function overload error in the OSL definitions of the matrix extract nodes. Fixes AcademySoftwareFoundation#2845.
Member
Author
|
Thanks to @msuzuki-nvidia for catching this, and I'm CC'ing @JHUbisoft as an FYI. |
jstone-lucasfilm
merged commit 2ae3121
into
AcademySoftwareFoundation:main
70 of 71 checks passed
Contributor
|
Thanks and sorry for the inconvenience |
Member
Author
|
Not your fault, @JHUbisoft, and ultimately it's on us to integrate OSL validation into our GitHub CI, so that this category of error gets caught early. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist fixes a function overload error in the OSL definitions of the matrix extract nodes.
Fixes #2845.