Bump node-forge from 1.3.3 to 1.4.0 in the npm_and_yarn group across 1 directory#1369
Conversation
dependabot
Bot
added
dependencies
|
@dependabot recreate |
Bumps the npm_and_yarn group with 1 update in the / directory: [node-forge](https://github.com/digitalbazaar/forge). Updates `node-forge` from 1.3.3 to 1.4.0 - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.3.3...v1.4.0) --- updated-dependencies: - dependency-name: node-forge dependency-version: 1.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
1ea5032 to
bbced73
Compare
5385f6f to
3e9f91e
Compare
bf61bce to
0494513
Compare
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
webpack-dev-server dependency.
Testing notes:
npm ci; npm run start- Ensure the process starts with a build
- Edit a CSS file
- Ensure a rebuild is triggered
- Ensure new styles are applied successfully
- Edit a JS file
- Ensure a build is triggered
- Ensure new scripts execute successfully.
It's all working fine locally but I've pushed up some messing around due to transition promises failing on CI.
| Cypress.on( 'uncaught:exception', ( err ) => { | ||
| if ( | ||
| err?.name === 'AbortError' && | ||
| err?.message?.includes( 'Transition was skipped' ) | ||
| ) { | ||
| return false; | ||
| } | ||
| } ); | ||
|
|
There was a problem hiding this comment.
This is an, apparently successful, way of working around the following error throwing on GitHub Action runs that does not occur locally.
I think it's something to do with view transitions not firing but removing wp_enqueue_view_transitions_admin_css from the admin CSS, see below, did not work on it's own.
AbortError: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection.
> Transition was skipped
When Cypress detects uncaught errors originating from your application it will automatically fail the current test.
This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event.
https://on.cypress.io/uncaught-exception-from-application
@dkotter Are you able to give me a logic check on this? It's happening in a bunch of repos.
There was a problem hiding this comment.
Yes, this looks fine and I landed on practically the same solution in ClassifAI: 10up/classifai@a9234df. Note we've since migrated ClassifAI to Playwright over Cypress and no longer have this problem
| /** | ||
| * Remove view transitions to prevent Cypress from failing on a transition promise. | ||
| */ | ||
| add_action( 'admin_enqueue_scripts', function() { |
There was a problem hiding this comment.
Is this still needed with the above fix?
github-project-automation
Bot
moved this from Code Review
to QA Testing
in Open Source Practice
This reverts commit 3e9f91e.
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
Dependency of webpack-dev-server.
Running npm run start works as expected.
github-project-automation
Bot
moved this from QA Testing
to Done
in Open Source Practice
3 participants
Bumps the npm_and_yarn group with 1 update in the / directory: node-forge.
Updates
node-forgefrom 1.3.3 to 1.4.0Changelog
Sourced from node-forge's changelog.
... (truncated)
Commits
fa385f9Release 1.4.0.07d4e16Update changelog.cb90fd9Update changelog.963e7c5Add unit test for "pseudonym"f0b6f5bAdd pseudonym OID3df48a3Fix missing CVE ID.2e49283Add x509basicConstraintscheck.bdecf11Add canonical signature scaler check for S < L.af094e6Add RSA padding and DigestInfo length checks.796eeb1Improve jsbn fix.