clamp no longer throws an error on NaN as min or max

tc39/proposal-math-clamp@d238779

Author: zloirock

CHANGELOG.md

@@ -1,5 +1,6 @@
 ## Changelog
 ##### Unreleased
+- `clamp` no longer throws an error on `NaN` as `min` or `max`, following [proposal-math-clamp#d2387791c265edf66fbe2455eab919016717ce6f](https://github.com/tc39/proposal-math-clamp/commit/d2387791c265edf66fbe2455eab919016717ce6f) 
 - Use `Get` in `Iterator.zipKeyed`, following [proposal-joint-iteration#43](https://github.com/tc39/proposal-joint-iteration/pull/43)
 - Fixed [several V8 bugs](https://github.com/zloirock/core-js/issues/1439) in `Uint8Array.fromHex` and `Uint8Array.prototype.{ setFromBase64, toBase64, toHex }`, thanks [**@brc-dd**](https://github.com/brc-dd)
 - Fixed some cases of `Set.prototype.{ symmetricDifference, union }` detection

packages/core-js/internals/math-clamp.js

@@ -1,13 +1,9 @@
 'use strict';
 var aNumber = require('../internals/a-number');
-var notANaN = require('../internals/not-a-nan');
 
 var $min = Math.min;
 var $max = Math.max;
 
 module.exports = function clamp(value, min, max) {
-  aNumber(value);
-  notANaN(aNumber(min));
-  notANaN(aNumber(max));
-  return $min(max, $max(min, value));
+  return $min($max(aNumber(value), aNumber(min)), aNumber(max));
 };

tests/unit-global/esnext.math.clamp.js

@@ -10,7 +10,6 @@ QUnit.test('Math.clamp', assert => {
   assert.same(clamp(4, 2, 6), 4);
   assert.same(clamp(6, 2, 4), 4);
 
-  assert.same(clamp(NaN, 4, 6), NaN, 'If value is NaN, return NaN.');
   assert.same(clamp(-0, 0, 1), 0, 'If value is -0𝔽 and min is +0𝔽, return +0𝔽.');
   assert.same(clamp(0, -0, 1), 0, 'If value is +0𝔽 and min is -0𝔽, return +0𝔽.');
   assert.same(clamp(-0, -1, 0), -0, 'If value is -0𝔽 and max is +0𝔽, return -0𝔽.');
@@ -20,9 +19,11 @@ QUnit.test('Math.clamp', assert => {
   assert.same(clamp(2, 0, -0), -0, 'min is +0𝔽 and max is -0𝔽');
   assert.same(clamp(2, 3, 1), 1, 'min > max');
 
-  assert.throws(() => clamp(Object(2), 1, 3), TypeError, 'If value is not a Number, throw a TypeError exception.');
+  assert.same(clamp(NaN, 3, 1), NaN, 'If value is NaN, return NaN.');
+  assert.same(clamp(2, NaN, 1), NaN, 'If min is NaN, return NaN.');
+  assert.same(clamp(2, 3, NaN), NaN, 'If max is NaN, return NaN.');
+
+  assert.throws(() => clamp({ valueOf: () => 2 }, 1, 3), TypeError, 'If value is not a Number, throw a TypeError exception');
   assert.throws(() => clamp(2, Object(1), 3), TypeError, 'If min is not a Number, throw a TypeError exception.');
-  assert.throws(() => clamp(2, NaN, 3), RangeError, 'If min is NaN, throw a RangeError exception.');
   assert.throws(() => clamp(2, 1, Object(3)), TypeError, 'If max is not a Number, throw a TypeError exception.');
-  assert.throws(() => clamp(2, 1, NaN), RangeError, 'If max is NaN, throw a RangeError exception.');
 });

tests/unit-global/esnext.number.clamp.js

@@ -10,7 +10,6 @@ QUnit.test('Number#clamp', assert => {
   assert.same(clamp.call(4, 2, 6), 4);
   assert.same(clamp.call(6, 2, 4), 4);
 
-  assert.same(clamp.call(NaN, 4, 6), NaN, 'If value is NaN, return NaN.');
   assert.same(clamp.call(-0, 0, 1), 0, 'If value is -0𝔽 and min is +0𝔽, return +0𝔽.');
   assert.same(clamp.call(0, -0, 1), 0, 'If value is +0𝔽 and min is -0𝔽, return +0𝔽.');
   assert.same(clamp.call(-0, -1, 0), -0, 'If value is -0𝔽 and max is +0𝔽, return -0𝔽.');
@@ -20,8 +19,11 @@ QUnit.test('Number#clamp', assert => {
   assert.same(clamp.call(2, 0, -0), -0, 'min is +0𝔽 and max is -0𝔽');
   assert.same(clamp.call(2, 3, 1), 1, 'min > max');
 
+  assert.same(clamp.call(NaN, 3, 1), NaN, 'If value is NaN, return NaN.');
+  assert.same(clamp.call(2, NaN, 1), NaN, 'If min is NaN, return NaN.');
+  assert.same(clamp.call(2, 3, NaN), NaN, 'If max is NaN, return NaN.');
+
+  assert.throws(() => clamp.call({ valueOf: () => 2 }, 1, 3), TypeError, 'If value is not a Number, throw a TypeError exception');
   assert.throws(() => clamp.call(2, Object(1), 3), TypeError, 'If min is not a Number, throw a TypeError exception.');
-  assert.throws(() => clamp.call(2, NaN, 3), RangeError, 'If min is NaN, throw a RangeError exception.');
   assert.throws(() => clamp.call(2, 1, Object(3)), TypeError, 'If max is not a Number, throw a TypeError exception.');
-  assert.throws(() => clamp.call(2, 1, NaN), RangeError, 'If max is NaN, throw a RangeError exception.');
 });

tests/unit-pure/esnext.math.clamp.js

@@ -8,7 +8,6 @@ QUnit.test('Math.clamp', assert => {
   assert.same(clamp(4, 2, 6), 4);
   assert.same(clamp(6, 2, 4), 4);
 
-  assert.same(clamp(NaN, 4, 6), NaN, 'If value is NaN, return NaN.');
   assert.same(clamp(-0, 0, 1), 0, 'If value is -0𝔽 and min is +0𝔽, return +0𝔽.');
   assert.same(clamp(0, -0, 1), 0, 'If value is +0𝔽 and min is -0𝔽, return +0𝔽.');
   assert.same(clamp(-0, -1, 0), -0, 'If value is -0𝔽 and max is +0𝔽, return -0𝔽.');
@@ -18,9 +17,11 @@ QUnit.test('Math.clamp', assert => {
   assert.same(clamp(2, 0, -0), -0, 'min is +0𝔽 and max is -0𝔽');
   assert.same(clamp(2, 3, 1), 1, 'min > max');
 
-  assert.throws(() => clamp(Object(2), 1, 3), TypeError, 'If value is not a Number, throw a TypeError exception.');
+  assert.same(clamp(NaN, 3, 1), NaN, 'If value is NaN, return NaN.');
+  assert.same(clamp(2, NaN, 1), NaN, 'If min is NaN, return NaN.');
+  assert.same(clamp(2, 3, NaN), NaN, 'If max is NaN, return NaN.');
+
+  assert.throws(() => clamp({ valueOf: () => 2 }, 1, 3), TypeError, 'If value is not a Number, throw a TypeError exception');
   assert.throws(() => clamp(2, Object(1), 3), TypeError, 'If min is not a Number, throw a TypeError exception.');
-  assert.throws(() => clamp(2, NaN, 3), RangeError, 'If min is NaN, throw a RangeError exception.');
   assert.throws(() => clamp(2, 1, Object(3)), TypeError, 'If max is not a Number, throw a TypeError exception.');
-  assert.throws(() => clamp(2, 1, NaN), RangeError, 'If max is NaN, throw a RangeError exception.');
 });

tests/unit-pure/esnext.number.clamp.js

@@ -7,7 +7,6 @@ QUnit.test('Number#clamp', assert => {
   assert.same(clamp(4, 2, 6), 4);
   assert.same(clamp(6, 2, 4), 4);
 
-  assert.same(clamp(NaN, 4, 6), NaN, 'If value is NaN, return NaN.');
   assert.same(clamp(-0, 0, 1), 0, 'If value is -0𝔽 and min is +0𝔽, return +0𝔽.');
   assert.same(clamp(0, -0, 1), 0, 'If value is +0𝔽 and min is -0𝔽, return +0𝔽.');
   assert.same(clamp(-0, -1, 0), -0, 'If value is -0𝔽 and max is +0𝔽, return -0𝔽.');
@@ -17,8 +16,11 @@ QUnit.test('Number#clamp', assert => {
   assert.same(clamp(2, 0, -0), -0, 'min is +0𝔽 and max is -0𝔽');
   assert.same(clamp(2, 3, 1), 1, 'min > max');
 
+  assert.same(clamp(NaN, 3, 1), NaN, 'If value is NaN, return NaN.');
+  assert.same(clamp(2, NaN, 1), NaN, 'If min is NaN, return NaN.');
+  assert.same(clamp(2, 3, NaN), NaN, 'If max is NaN, return NaN.');
+
+  assert.throws(() => clamp({ valueOf: () => 2 }, 1, 3), TypeError, 'If value is not a Number, throw a TypeError exception');
   assert.throws(() => clamp(2, Object(1), 3), TypeError, 'If min is not a Number, throw a TypeError exception.');
-  assert.throws(() => clamp(2, NaN, 3), RangeError, 'If min is NaN, throw a RangeError exception.');
   assert.throws(() => clamp(2, 1, Object(3)), TypeError, 'If max is not a Number, throw a TypeError exception.');
-  assert.throws(() => clamp(2, 1, NaN), RangeError, 'If max is NaN, throw a RangeError exception.');
 });