fix: you are never your own guest

GitHub logins are case-insensitive, but stats.jq compared them
case-sensitively. $login arrives from the CLI in whatever casing was
typed while API payloads carry the canonical spelling, so `gh-pet
willjames` failed to recognize its own "WillJames/repo" events as its
own.

The visitor list filtered self out via startswith($login + "/") — a
proxy for "not me" that silently stopped holding under a case mismatch,
promoting you to a visitor on your own stage. On a case-insensitive
filesystem the guest cache lookup then resolves to your own state.env,
so the pet renders standing next to itself.

Bind the login downcased once and state the invariant on the extracted
owner rather than trusting the repo-prefix proxy. Same root cause fixed
in two siblings: $outbound7 counted your own repos as outbound comments
on others' repos (inflating social), and the $comms bond ledger could
list you against yourself.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: “William

gh-pet/lib/stats.jq

@@ -38,6 +38,12 @@
   ([ $EV[] | select((.created_at | fromdateiso8601) <= $NOW) ]) as $EV
 | ([ $ST[] | select((.starred_at // null) == null or ((.starred_at | fromdateiso8601) <= $NOW)) ]) as $ST
 
+# who we are, for comparison against API payloads. GitHub logins are case-
+# insensitive, but $login arrives from the CLI in whatever casing was typed while
+# payloads carry the canonical spelling — compare downcased, or `gh-pet willjames`
+# fails to recognize its own "WillJames/repo" events as its own.
+| (($U.login // $login) | ascii_downcase) as $me
+
 # ── account & identity facts ─────────────────────────────────────────────────
 | ($U.created_at // "2020-01-01T00:00:00Z") as $created
 | (dago($created)) as $acct_days
@@ -157,16 +163,19 @@
     | select(.type == "IssueCommentEvent" or .type == "PullRequestReviewEvent"
              or .type == "PullRequestReviewCommentEvent" or .type == "CommitCommentEvent")
     | select(dago(.created_at) < 7)
-    | select((.repo.name // "") | startswith($login + "/") | not) ] | length) as $outbound7
+    | select((.repo.name // "" | ascii_downcase) | startswith($me + "/") | not) ] | length) as $outbound7
 | ((7 * ($outbound7 | sqrt) + ([($FW | length), 20] | min)) | clamp(0; 100) | round) as $social
 # visitors: whoever you've interacted with in the LAST HOUR — their pets
-# drop by on the stage (owners of repos you commented/reviewed on)
+# drop by on the stage (owners of repos you commented/reviewed on).
+# You are never your own guest: the repo filter is only a proxy for that, so the
+# owner is checked against $me directly rather than trusting the proxy to hold.
 | ([ $EV[]
     | select(.type == "IssueCommentEvent" or .type == "PullRequestReviewEvent"
              or .type == "PullRequestReviewCommentEvent" or .type == "CommitCommentEvent")
     | select(dago(.created_at) < (1 / 24))
-    | select((.repo.name // "") | startswith($login + "/") | not)
-    | ((.repo.name // "") | split("/")[0]) | select(. != "") ]
+    | select((.repo.name // "" | ascii_downcase) | startswith($me + "/") | not)
+    | ((.repo.name // "") | split("/")[0])
+    | select(. != "" and (ascii_downcase != $me)) ]
    | unique | .[0:3]) as $visitors
 # bond ledger: who you actually talk to — for every comment/review event,
 # the counterpart is the author of the issue/PR (person-level, so org-repo
@@ -178,7 +187,7 @@
              or .type == "PullRequestReviewCommentEvent" or .type == "CommitCommentEvent")
     | (.payload.issue.user.login // .payload.pull_request.user.login
        // ((.repo.name // "") | split("/")[0]))
-    | select(. != "" and . != $login) ]
+    | select(. != "" and (ascii_downcase != $me)) ]
    | group_by(.) | sort_by(-length) | .[0:30]
    | map("\(.[0])|\(length)") | join(";")) as $comms
 

gh-pet/tests/run.sh

@@ -76,6 +76,27 @@ _hap=$(sed -n "s/^HAPPINESS='\([0-9]*\)'.*/\1/p" <<<"$ASP")
 _cap=$(sed -n "s/^CAPPED_BY='\(.*\)'\$/\1/p" <<<"$ASP")
 if [[ -n $_hap ]] && (( _hap > 60 )) && [[ -z $_cap ]]; then ok "aspirational stats never hard-cap (happiness $_hap > 60, uncapped)"; else fail "an aspirational stat capped a healthy pet (happiness=${_hap:-none} capped_by='$_cap')"; fi
 
+echo "· you are never your own guest: GitHub logins are case-insensitive, so"
+echo "  'gh-pet SELF' must still recognize self/app as its own — otherwise the"
+echo "  owner of every repo you touch reads as a stranger and you turn up on your"
+echo "  own stage as a visitor (and in your own outbound social score)"
+_vev=$(jq -n --argjson n "$_now" '[
+  {type:"IssueCommentEvent",created_at:(($n-600)|todate),repo:{name:"self/app"}},
+  {type:"IssueCommentEvent",created_at:(($n-600)|todate),repo:{name:"mona/hello"},
+   payload:{issue:{user:{login:"mona"}}}}]')
+VIS=$(jq -n -r --arg now "$_now" --arg login SELF \
+  --argjson user '[{"id":3151702,"login":"self","created_at":"2019-03-14T09:00:00Z"}]' \
+  --argjson events "[$_vev]" \
+  --argjson repos null --argjson merged null --argjson approved null --argjson changesreq null \
+  --argjson reviewedby null --argjson starred null --argjson stale null --argjson alerts null \
+  --argjson calendar null --argjson notifications null --argjson medals null \
+  --argjson orgs null --argjson following null -f "$ROOT/lib/stats.jq" 2>&1)
+_vis=$(sed -n "s/^VISITORS='\(.*\)'\$/\1/p" <<<"$VIS")
+if [[ " $_vis " != *" self "* && " $_vis " != *" SELF "* ]]; then ok "self never appears in its own visitor list (VISITORS='$_vis')"; else fail "the pet is visiting itself (VISITORS='$_vis')"; fi
+if [[ " $_vis " == *" mona "* ]]; then ok "a real last-hour interaction still drops by (mona)"; else fail "guest list lost a real visitor (VISITORS='$_vis')"; fi
+_out=$(sed -n "s/^OUTBOUND7='\([0-9]*\)'\$/\1/p" <<<"$VIS")
+if [[ $_out == 1 ]]; then ok "outbound social counts others' repos only, whatever the login's casing"; else fail "own-repo comments leaked into outbound social (OUTBOUND7=${_out:-none}, want 1)"; fi
+
 echo "· unauthenticated / public-only path (plan.md §9.2): the pure function still"
 echo "  derives when health is unknown and the contribution calendar is absent"
 UARGS=(-r --arg now "$(date +%s)" --arg login octotest)