fix(cloudflare): prebundle JSON logger when enabled (#17850)

Author: matthewp

.changeset/nine-streets-retire.md

@@ -0,0 +1,5 @@
+---
+'@astrojs/cloudflare': patch
+---
+
+Fixes React SSR failures on the first Cloudflare dev request when JSON logging is enabled

packages/integrations/cloudflare/src/index.ts

@@ -359,6 +359,9 @@ export default function createIntegration({
 													...(prebundleContentRuntime ? (['astro/content/runtime'] as const) : []),
 													'astro/compiler-runtime',
 													'astro/jsx-runtime',
+													...(config.logger?.entrypoint === 'astro/logger/json'
+														? ['astro/logger/json']
+														: []),
 													'astro/app/entrypoint/dev',
 													'astro/middleware',
 													'astro/virtual-modules/middleware.js',

packages/integrations/cloudflare/test/typegen-phase.test.ts

@@ -17,7 +17,10 @@ interface OptimizeDepsPatch {
 	optimizeDeps?: { noDiscovery?: boolean; include?: string[]; exclude?: string[] };
 }
 
-async function runConfigSetup(command: 'dev' | 'build' | 'sync') {
+async function runConfigSetup(
+	command: 'dev' | 'build' | 'sync',
+	loggerConfig?: { entrypoint: string },
+) {
 	const integration = cloudflare();
 	let updatedConfig: { vite: { plugins: unknown[] } } | undefined;
 
@@ -31,6 +34,7 @@ async function runConfigSetup(command: 'dev' | 'build' | 'sync') {
 			experimental: {},
 			vite: {},
 			image: {},
+			logger: loggerConfig,
 		},
 		updateConfig(config: { vite: { plugins: unknown[] } }) {
 			updatedConfig = config;
@@ -116,5 +120,21 @@ describe('type generation phase (build and sync)', () => {
 			assert.ok(include.includes('astro/actions/runtime/entrypoints/server.js'));
 			assert.ok(include.includes('astro/actions/runtime/entrypoints/route.js'));
 		});
+
+		it('only prebundles the JSON logger when it is enabled', async () => {
+			const defaultConfig = await runConfigSetup('dev');
+			const defaultInclude =
+				defaultConfig.configEnvironment('ssr', {})?.optimizeDeps?.include ?? [];
+			assert.ok(!defaultInclude.includes('astro/logger/json'));
+
+			const consoleConfig = await runConfigSetup('dev', { entrypoint: 'astro/logger/console' });
+			const consoleInclude =
+				consoleConfig.configEnvironment('ssr', {})?.optimizeDeps?.include ?? [];
+			assert.ok(!consoleInclude.includes('astro/logger/json'));
+
+			const jsonConfig = await runConfigSetup('dev', { entrypoint: 'astro/logger/json' });
+			const jsonInclude = jsonConfig.configEnvironment('ssr', {})?.optimizeDeps?.include ?? [];
+			assert.ok(jsonInclude.includes('astro/logger/json'));
+		});
 	});
 });