CI: v-apps-compile has 6 pre-existing failures blocking PR CI (vtcc, discord.v, UI, v-analyzer)

[quaesitor-scientiam]

Summary

The v-apps-compile job has 6 steps that fail on master (confirmed in run 24272923504), meaning every PR sees these failures regardless of its content. This makes it hard to distinguish real regressions from pre-existing noise.

Failing steps (all pre-existing on master)

1. Test vtcc

Error: V panic: result not set (failed) during vtcc/make.vsh, caused by a C compilation error:

src/tccelf.v:15:21: warning: value `0x80000000` overflows `int`, this will be considered hard error soon
const shf_private = int(0x8000_0000)
cc: error: invalid operand types for binary operation

Fix needed in: https://github.com/felipensp/vtcc
Change const shf_private = int(0x8000_0000) → const shf_private = u32(0x8000_0000) (and similarly shf_dynsym = int(0x4000_0000) → u32). The overflow causes bad generated C, and make.vsh does not handle the resulting compilation error, triggering panic_result_not_set.

2. Test discord.v

Error: Hundreds of instances across src/*.v:

error: function `x.json2.raw_decode` has been deprecated since 2025-10-10; use `decode[json2.Any]` instead

Fix needed in: the discord.v repo — replace all x.json2.raw_decode(s)! calls with json2.decode[json2.Any](s)!.

3. Build V UI examples

Errors: unused parameter and immutable variable errors in ~/.vmodules/ui/component/*.v and 7guis/*.v.
Fix needed in: https://github.com/vlang/ui — add _ prefix to unused callback parameters and declare mutable receivers with mut.

4. Install UI through VPM and make sure its examples compile

Same root cause as #3.

5. Build vlang/v-analyzer

Error: Type incompatibilities in v-analyzer's src/analyzer/psi/TypeInferer.v:

error: incompatible type for argument 1 of 'src__analyzer__psi__infer_type'
error: invalid initializer
error: incompatible types when returning type 'int' but 'Type' was expected

Fix needed in: https://github.com/vlang/v-analyzer

6. Format vlang/v-analyzer

Errors:

• unexpected token '$' in src/metadata/stubs/vweb.v:36 (pub const $vweb = VWebTemplate{}) — vfmt cannot handle this stub syntax
• Unformatted attribute stubs (Deprecated.v, DeprecatedAfter.v, compile_time.v)
• const names cannot contain uppercase letters for @FN, @METHOD, etc. in compile_time.v

Fix needed in: https://github.com/vlang/v-analyzer

Action items

• PR to felipensp/vtcc: fix shf_private/shf_dynsym overflow (use u32) and handle make.vsh errors
• PR to discord.v repo: replace x.json2.raw_decode with json2.decode[json2.Any]
• PR to vlang/ui: fix unused params and mut receiver issues
• PR to vlang/v-analyzer: fix TypeInferer type mismatches and stub formatting issues

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

[quaesitor-scientiam]

Upstream issues filed

• src/tccelf.v: int(0x8000_0000) overflows int, causing CI failure in vlang/v felipensp/vtcc#6 — vtcc int(0x8000_0000) overflow + C compilation error
• x.json2.raw_decode deprecated since 2025-10-10, now a compile error — breaks vlang/v CI vcv88/discord.v#21 — x.json2.raw_decode deprecated-as-error
• Build broken: TypeInferer type incompatibilities + vfmt fails on stub syntax v-analyzer#182 — TypeInferer type incompatibilities + vfmt $vweb stub failure
• Build broken: unused parameters and immutable receiver errors break vlang/v CI ui#621 — unused parameters + immutable receiver errors

Notes on root causes

discord.v: The deprecation of x.json2.raw_decode became enforced as a compile error after 2025-10-10. The pinned commit ce9ff457 is the latest commit in that repo (last activity Dec 2024) so there is no newer commit to pin to. The repo needs to be updated by its maintainer, or the test step should be temporarily disabled.

vtcc: The overflow warning at src/tccelf.v:15 (const shf_private = int(0x8000_0000)) is still a warning (not yet a hard error), but a separate C compilation error from TCC (invalid operand types for binary operation at generated C line ~18827) is the actual blocker. This may be caused by the recent stable branch merge (June 2025). Needs investigation in that repo.

v-analyzer: The TypeInferer.v type incompatibilities (incompatible type for argument of infer_type) were already present before this PR, suggesting a recent V API change broke v-analyzer's build.

vlang/ui: Unused parameter and immutable receiver errors — the UI module hasn't kept up with V's stricter checking.

[quaesitor-scientiam]

Detailed findings and action plan

---

1. vtcc (Test vtcc)

Root cause (two separate problems):

a) src/tccelf.v:15 — const shf_private = int(0x8000_0000) overflows int. Still a warning in V today, but will become a hard error. The overflow causes V to generate C code where this constant participates in binary operations that TCC (the embedded compiler) then rejects:

cc: warning: assignment makes pointer from integer without a cast
cc: error: invalid operand types for binary operation  (generated C ~line 18827)

b) When make.vsh's build_steps() returns error('failed') (because vtcc.o compilation failed), the ! propagation in the .vsh main context produces V panic: result not set (failed) instead of a clean error. This is cosmetic — the real cause is (a).

Fix needed:

• In felipensp/vtcc: change const shf_private = int(0x8000_0000) → u32(0x8000_0000) (and propagate the type change to the new_section/new_symtab callers which currently accept int for flags). Filed as src/tccelf.v: int(0x8000_0000) overflows int, causing CI failure in vlang/v felipensp/vtcc#6.
• While waiting for upstream: add a sed patch in .github/workflows/compile_v_with_vtcc.sh after the git clone:

  sed -i 's/const shf_private = int(0x8000_0000)/const shf_private = u32(0x8000_0000)/' src/tccelf.v
  sed -i 's/sh_flags int/sh_flags u32/g' src/tccelf.v   # if needed

  Note: this only fixes the overflow warning. The C compilation error at line ~18827 may require separate investigation.

---

2. discord.v (Test discord.v)

Root cause: The CI pins to ce9ff457 (Dec 2024), which is the latest and only commit to this repo since Aug 2024. The x.json2.raw_decode function was deprecated-as-error in V on 2025-10-10. The repo has hundreds of call sites and appears unmaintained.

Fix options (pick one):

• Option A (preferred): Temporarily disable the discord.v step in .github/workflows/compile_discordv.sh with a comment referencing x.json2.raw_decode deprecated since 2025-10-10, now a compile error — breaks vlang/v CI vcv88/discord.v#21, until the upstream updates.
• Option B: Have someone in the V team fork discord.v, bulk-replace x.json2.raw_decode(s)! → json2.decode[json2.Any](s)! across all files in src/, and update the pin in compile_discordv.sh to the new fork/commit.
• Option C: Reach out to discord.v maintainer with a draft PR.

---

3. V UI examples (Build V UI examples + Install UI through VPM)

Root cause: vlang/ui has not kept up with V's stricter checking:

• unused parameter in event callbacks (component/accordion.v, grid.v, colorsliders.v, gg_app.v, rasterview.v, splitpanel.v, tabs.v, 7guis/*.v)
• immutable receiver — receiver must be declared mut (component/fontchooser.v, hideable.v)

Fix: This is a V team repo (vlang/ui). Simple fixes:

• Rename unused callback params e, keycode, cp, c, btn, d → _e, _keycode, etc.
• Add mut to receivers fc and w in the relevant functions.
• Filed as Build broken: unused parameters and immutable receiver errors break vlang/v CI ui#621. The V team can directly submit a PR to vlang/ui.

---

4. v-analyzer build (Build vlang/v-analyzer)

Root cause: Almost certainly the April 6, 2026 batch commit 82292bd60 ("all: lots of fixes"), which changed mut auto-deref parameter type resolution in vlib/v/checker/check_types.v:

-  && (!arg.is_mut || arg.expr.is_auto_deref_var()) {
+  && (!arg.is_mut || !arg.expr.is_auto_deref_var()) {

This flip changed how mut arguments that are auto-deref vars have their types resolved during generic inference. v-analyzer's TypeInferer.v uses mut visited map[string]types.Type (where types.Type is an interface) as a parameter in several functions. After this change, V now sees the type of this argument differently at call sites, causing:

• incompatible type for argument 1 of 'infer_type' (7+ callers in 4 files)
• invalid initializer at mut visited := map[string]types.Type{}
• incompatible types when returning type 'int' but 'Type' was expected (v-analyzer's types.unknown_type constant is being misidentified)

Fix options:

• Option A (preferred): Investigate whether 82292bd60's check_types.v change is correct or introduces a regression for mut Interface-typed map parameters, and fix if needed. This is a V-side fix.
• Option B: Help v-analyzer update TypeInferer.v to match the new semantics (if the V change is intentional). Filed as Build broken: TypeInferer type incompatibilities + vfmt fails on stub syntax v-analyzer#182.

---

5. v-analyzer format (Format vlang/v-analyzer)

Root cause (two separate vfmt issues):

a) pub const $vweb = VWebTemplate{} in src/metadata/stubs/vweb.v — vfmt errors on $-prefixed const names instead of handling them gracefully. The $vweb is intentional v-analyzer stub syntax for VLS.

b) pub const @FN = '', pub const @METHOD = '', etc. in compile_time.v — V's checker rejects uppercase names in constants, but @-prefixed compile-time constant stubs (@FN, @METHOD, @STRUCT, etc.) require uppercase.

c) attributes/Deprecated.v and attributes/DeprecatedAfter.v are reported as not formatted (likely a vfmt output difference).

Fix options:

• For (a): vfmt should return exit code 5 (internal error, tolerated by the v-analyzer CI step) rather than exit code 1 for $-prefixed const names it can't parse. OR v-analyzer needs to rewrite these stubs to use a different syntax.
• For (b): Either V allows @-prefixed const names with uppercase (they're reserved identifiers), or v-analyzer changes the stub approach.
• Filed in Build broken: TypeInferer type incompatibilities + vfmt fails on stub syntax v-analyzer#182.

---

Prioritized action plan

Priority	Action	Owner	Effort
P1	Fix vlang/ui: rename unused params + add mut to receivers	V team	Small (1–2h)
P2	Investigate if 82292bd60 broke mut Interface map params in v-analyzer and fix or document	V team	Medium
P3	Temporarily disable discord.v CI step, add comment referencing vcv88/discord.v#21	V team	Trivial
P4	Apply sed workaround for vtcc overflow in CI script while vtcc#6 is resolved	V team	Trivial
P5	Fix vfmt to not error (exit 1) on $-prefixed const names — return exit 5 instead	V team	Small
P6	Coordinate with v-analyzer on TypeInferer fix once V-side behavior is clarified	V team + v-analyzer	Medium
P7	Long-term: vtcc, discord.v upstream fixes	External maintainers	—

P1, P3, P4 can be done immediately and would clear 4 of the 6 failing steps right away.

[quaesitor-scientiam]

Progress update — PR #26858 (vtcc + discord.v CI fixes)

PR #26858 addresses P3 and P4 from the action plan.

What changed

P4 — vtcc (Test vtcc): Added a sed patch in .github/workflows/compile_v_with_vtcc.sh that runs immediately after cloning vtcc, before v run make.vsh:

sed -i 's/const shf_private = int(0x8000_0000)/const shf_private = u32(0x8000_0000)/' vtcc/src/tccelf.v

This fixes the integer overflow at src/tccelf.v:15 that causes TCC to reject the generated C with invalid operand types for binary operation. Upstream fix tracked at felipensp/vtcc#6.

P3 — discord.v (Test discord.v): The yml step was already guarded with ${{ false && ... }}. Updated compile_discordv.sh to replace the old commented-out code with a clear comment block explaining why the step is disabled and what needs to happen to re-enable it — keeping the original test logic intact so re-enabling is a one-liner change in the yml. (An earlier version of the PR had an exit 0 in the script; this was removed after a Codex review suggestion pointing out the false-green risk.)

Current PR status

Fix	PR	Status
P1 — vlang/ui unused params + unsafe casts	vlang/ui#622	Open, awaiting maintainer review
P2 — v-analyzer build	—	Already resolved upstream; no V-side fix needed
P3 — discord.v CI step	#26858	Open
P4 — vtcc int overflow workaround	#26858	Open
P5 — vfmt exit code 7 → 5 for mixed errors	#26857	Open

Note: the tools-* CI failures visible in #26857 and #26858 are pre-existing on master (f882c8174 — "v2: implements") and unrelated to these PRs.

[JalonSolov]

Rename unused callback params e, keycode, cp, c, btn, d → _e, _keycode, etc.

Won't do any good, as they'll still be unused parameters. The correct answer is to rename them where required to just _, the "empty name placeholder".

[quaesitor-scientiam]

@JalonSolov Agreed — and that's exactly what vlang/ui#622 does. The action plan description above used _e, _keycode etc. as shorthand to indicate which parameters were being renamed, but the actual PR uses the bare _ blank identifier throughout, e.g.:

fn accordion_click(c &ui.CanvasLayout, _ ui.MouseEvent) {
fn alpha_on_char(textbox &ui.TextBox, _ u32) {
fn grid_scroll(_ &ui.CanvasLayout, _ ui.ScrollEvent) {}

The wording in the action plan was imprecise — apologies for the confusion.