Merge pull request #19 from Milly/rejects-instead-throws

🐛 returns rejected Promise instead throws Error

Author: lambdalisue

session.ts

@@ -70,27 +70,26 @@ export class Session {
 
   /**
    * Send a command or a message to the peer.
+   * If the session is not running, the promise will be rejected with {@link Error}.
    * @param data The data to send.
-   * @throws If the session is not running.
    */
   send(data: Command | Message): Promise<void> {
     if (!this.#running) {
-      throw new Error("Session is not running");
+      return Promise.reject(new Error("Session is not running"));
     }
     const { innerWriter } = this.#running;
     return innerWriter.write(data);
   }
 
   /**
    * Receive a message from the peer.
+   * If the session is not running or the message ID is already reserved, the promise will be rejected with {@link Error}.
    * @param msgid The message ID to receive.
    * @returns The received message.
-   * @throws If the session is not running.
-   * @throws If the message ID is already reserved.
    */
   recv(msgid: number): Promise<Message> {
     if (!this.#running) {
-      throw new Error("Session is not running");
+      return Promise.reject(new Error("Session is not running"));
     }
     const { reservator } = this.#running;
     return reservator.reserve(msgid);
@@ -157,25 +156,25 @@ export class Session {
 
   /**
    * Wait until the session is shutdown.
+   * If the session is not running, the promise will be rejected with {@link Error}.
    * @returns A promise that is fulfilled when the session is shutdown.
-   * @throws If the session is not running.
    */
   wait(): Promise<void> {
     if (!this.#running) {
-      throw new Error("Session is not running");
+      return Promise.reject(new Error("Session is not running"));
     }
     const { waiter } = this.#running;
     return waiter;
   }
 
   /**
    * Shutdown the session.
+   * If the session is not running, the promise will be rejected with {@link Error}.
    * @returns A promise that is fulfilled when the session is shutdown.
-   * @throws If the session is not running.
    */
   shutdown(): Promise<void> {
     if (!this.#running) {
-      throw new Error("Session is not running");
+      return Promise.reject(new Error("Session is not running"));
     }
     // Abort consumer to shutdown session properly.
     const { consumerController, waiter } = this.#running;
@@ -185,12 +184,12 @@ export class Session {
 
   /**
    * Shutdown the session forcibly.
+   * If the session is not running, the promise will be rejected with {@link Error}.
    * @returns A promise that is fulfilled when the session is shutdown.
-   * @throws If the session is not running.
    */
   forceShutdown(): Promise<void> {
     if (!this.#running) {
-      throw new Error("Session is not running");
+      return Promise.reject(new Error("Session is not running"));
     }
     // Abort consumer and producer to shutdown session forcibly.
     const { consumerController, producerController, waiter } = this.#running;

session_test.ts

@@ -48,7 +48,7 @@ Deno.test("Session.send", async (t) => {
       const { session } = createDummySession();
 
       const command = buildRedrawCommand();
-      assertThrows(
+      assertRejects(
         () => session.send(command),
         Error,
         "Session is not running",
@@ -95,7 +95,7 @@ Deno.test("Session.recv", async (t) => {
     () => {
       const { session } = createDummySession();
 
-      assertThrows(() => session.recv(-1), Error, "Session is not running");
+      assertRejects(() => session.recv(-1), Error, "Session is not running");
     },
   );
 
@@ -161,7 +161,7 @@ Deno.test("Session.wait", async (t) => {
     () => {
       const { session } = createDummySession();
 
-      assertThrows(() => session.wait(), Error, "Session is not running");
+      assertRejects(() => session.wait(), Error, "Session is not running");
     },
   );
 
@@ -200,7 +200,7 @@ Deno.test("Session.shutdown", async (t) => {
     () => {
       const { session } = createDummySession();
 
-      assertThrows(() => session.shutdown(), Error, "Session is not running");
+      assertRejects(() => session.shutdown(), Error, "Session is not running");
     },
   );
 
@@ -251,7 +251,7 @@ Deno.test("Session.forceShutdown", async (t) => {
     () => {
       const { session } = createDummySession();
 
-      assertThrows(
+      assertRejects(
         () => session.forceShutdown(),
         Error,
         "Session is not running",