Move DHCP status update to SendPollReply

Update art_poll_reply_.status2 DHCP bit at reply time by moving the network::iface::Dhcp() check from ArtNetNode::Start() into ArtNetNode::SendPollReply(). This ensures the DHCP/manual IP flag reflects the current runtime network state when sending poll replies. Removed the startup-time update and added the check just before processing the poll reply.

Author: vanvught

lib-artnet/src/node/artnetnode.cpp

@@ -172,8 +172,6 @@ void ArtNetNode::Start()
     art_poll_reply_.status2 &= static_cast<uint8_t>(~artnet::Status2::kSacnAbleToSwitch);
     art_poll_reply_.status2 |=
         artnet::Status2::kPortAddress15Bit | (artnet::kVersion >= 4 ? artnet::Status2::kSacnAbleToSwitch : artnet::Status2::kSacnNoSwitch);
-    art_poll_reply_.status2 &= static_cast<uint8_t>(~artnet::Status2::kIpDhcp);
-    art_poll_reply_.status2 |= network::iface::Dhcp() ? artnet::Status2::kIpDhcp : artnet::Status2::kIpManualy;
     art_poll_reply_.status2 &= static_cast<uint8_t>(~artnet::Status2::kDhcpCapable);
     art_poll_reply_.status2 |= network::iface::IsDhcpCapable() ? artnet::Status2::kDhcpCapable : static_cast<uint8_t>(0);
 #if defined(ENABLE_HTTPD) && defined(ENABLE_CONTENT)

lib-artnet/src/node/artnetnodehandlepoll.cpp

@@ -250,6 +250,9 @@ void ArtNetNode::SendPollReply(uint32_t port_index, uint32_t destination_ip, art
         art_poll_reply_.user_lo = static_cast<uint8_t>(kUserData);
         art_poll_reply_.user_hi = static_cast<uint8_t>(kUserData >> 8);
     }
+	
+	art_poll_reply_.status2 &= static_cast<uint8_t>(~artnet::Status2::kIpDhcp);
+	art_poll_reply_.status2 |= network::iface::Dhcp() ? artnet::Status2::kIpDhcp : artnet::Status2::kIpManualy;
 
     ProcessPollReply(port_index);