Remove 'nonword' property from FirstPerson.yml - #72
Closed
ChrisChinchilla wants to merge 1 commit into
Closed
Conversation
I am not sure if this has any effect on anything else, but this property seems to cause issues with the underlines in extensions that use the language server, removing it fixes that. If you feel it's needed, I'll try and find another solution.
jdkato
added a commit
that referenced
this pull request
Jul 30, 2026
PR #72 reports bad underlines in editors using the language server and proposes removing `nonword: true`. The diagnosis is right, the change isn't sufficient: the token consumes the leading space, so mid-sentence "Yesterday I walked" matches " I" and the alert covers one character too many, reading "such as ' I'". Removing `nonword` leaves that unchanged. Using lookaround makes the match the pronoun itself. The two `I` tokens collapse into one, since they differed only in the delimiter they required. `nonword` goes too, which the PR was right about for a different reason: it prevents a project Vocab from applying to the rule. No fixture covered this. Every `I` in the fixtures sits at the start of a line, where `^` matches zero-width and no space is consumed, so the existing expectations were identical either way. Added a mid-sentence case, which moves from column 10 with ' I' to column 11 with 'I'.
Member
|
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if this has any effect on anything else, but this property seems to cause issues with the underlines in extensions that use the language server, removing it fixes that.
If you feel it's needed, I'll try and find another solution.