Skip to content

Remove 'nonword' property from FirstPerson.yml - #72

Closed
ChrisChinchilla wants to merge 1 commit into
vale-cli:masterfrom
ChrisChinchilla:patch-1
Closed

Remove 'nonword' property from FirstPerson.yml#72
ChrisChinchilla wants to merge 1 commit into
vale-cli:masterfrom
ChrisChinchilla:patch-1

Conversation

@ChrisChinchilla

Copy link
Copy Markdown

I am not sure if this has any effect on anything else, but this property seems to cause issues with the underlines in extensions that use the language server, removing it fixes that.

If you feel it's needed, I'll try and find another solution.

I am not sure if this has any effect on anything else, but this property seems to cause issues with the underlines in extensions that use the language server, removing it fixes that.

If you feel it's needed, I'll try and find another solution.
jdkato added a commit that referenced this pull request Jul 30, 2026
PR #72 reports bad underlines in editors using the language server and
proposes removing `nonword: true`. The diagnosis is right, the change
isn't sufficient: the token consumes the leading space, so mid-sentence
"Yesterday I walked" matches " I" and the alert covers one character too
many, reading "such as ' I'". Removing `nonword` leaves that unchanged.

Using lookaround makes the match the pronoun itself. The two `I` tokens
collapse into one, since they differed only in the delimiter they
required.

`nonword` goes too, which the PR was right about for a different reason:
it prevents a project Vocab from applying to the rule.

No fixture covered this. Every `I` in the fixtures sits at the start of a
line, where `^` matches zero-width and no space is consumed, so the
existing expectations were identical either way. Added a mid-sentence
case, which moves from column 10 with ' I' to column 11 with 'I'.
@jdkato

jdkato commented Jul 30, 2026

Copy link
Copy Markdown
Member

Fixed.

@jdkato jdkato closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants