fix: address review comments

- CoroutineScopeHolder: implement Disposable to cancel parentJob on project disposal
- IdeaAgentViewModel: preserve partial streaming output on abort
- IdeaAgentApp: simplify AgentTab structure by removing nested Box
- build.gradle.kts: extract mppVersion variable to avoid duplication
- DomainDictAgent: normalize path separators and skip empty package paths

Author: phodal

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/subagent/DomainDictAgent.kt

@@ -341,10 +341,14 @@ class DomainDictAgent(
     /**
      * Extract package path from file path
      * e.g., "src/main/kotlin/cc/unitmesh/agent/Tool.kt" -> "cc/unitmesh/agent"
+     * Handles both Unix (/) and Windows (\) path separators.
      */
     private fun extractPackagePath(filePath: String): String {
+        // Normalize path separators to forward slash for cross-platform compatibility
+        val normalizedPath = filePath.replace('\\', '/')
+
         // Remove common source prefixes
-        val cleanPath = filePath
+        val cleanPath = normalizedPath
             .replace(Regex("^.*/src/(main|common)/(kotlin|java|scala)/"), "")
             .replace(Regex("^.*/src/"), "")
             .replace(Regex("^src/(main|common)/(kotlin|java|scala)/"), "")
@@ -368,7 +372,10 @@ class DomainDictAgent(
         val prioritizedFiles = if (importantPackages.isNotEmpty()) {
             insights.hotFiles.sortedByDescending { file ->
                 val pkg = extractPackagePath(file.path)
-                if (importantPackages.any { pkg.startsWith(it) || it.startsWith(pkg) }) 2 else 1
+                // Skip empty package paths to avoid matching all entries
+                if (pkg.isEmpty()) 1
+                else if (importantPackages.any { pkg.startsWith(it) || it.startsWith(pkg) }) 2
+                else 1
             }
         } else {
             insights.hotFiles

mpp-idea/build.gradle.kts

@@ -9,7 +9,8 @@ plugins {
 }
 
 group = "cc.unitmesh.devins"
-version = project.findProperty("mppVersion") as String? ?: "0.3.2"
+val mppVersion = project.findProperty("mppVersion") as String? ?: "0.3.2"
+version = mppVersion
 
 kotlin {
     jvmToolchain(21)
@@ -69,7 +70,7 @@ dependencies {
 intellijPlatform {
     pluginConfiguration {
         name = "AutoDev Compose UI"
-        version = project.findProperty("mppVersion") as String? ?: "0.3.2"
+        version = mppVersion
 
         ideaVersion {
             sinceBuild = "252"

mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/services/CoroutineScopeHolder.kt

@@ -1,22 +1,24 @@
 package cc.unitmesh.devins.idea.services
 
+import com.intellij.openapi.Disposable
 import com.intellij.openapi.components.Service
 import com.intellij.openapi.components.Service.Level
 import com.intellij.openapi.project.Project
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.SupervisorJob
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.CoroutineName
-import kotlinx.coroutines.Job
+import kotlinx.coroutines.cancel
 
 /**
  * A service-level class that provides and manages coroutine scopes for a given project.
+ * Implements [Disposable] to properly cancel all coroutines when the project is closed.
  *
  * @constructor Initializes the [CoroutineScopeHolder] with a project instance.
  * @param project The project this service is associated with.
  */
 @Service(Level.PROJECT)
-class CoroutineScopeHolder(private val project: Project) {
+class CoroutineScopeHolder(private val project: Project) : Disposable {
 
     private val parentJob = SupervisorJob()
     private val projectWideCoroutineScope: CoroutineScope = CoroutineScope(parentJob + Dispatchers.Default)
@@ -37,5 +39,12 @@ class CoroutineScopeHolder(private val project: Project) {
         val childJob = SupervisorJob(parentJob)
         return CoroutineScope(childJob + Dispatchers.Default + CoroutineName(name))
     }
+
+    /**
+     * Cancels all coroutines when the project is disposed.
+     */
+    override fun dispose() {
+        parentJob.cancel()
+    }
 }
 

mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentApp.kt

@@ -256,22 +256,20 @@ private fun AgentTab(
         JewelTheme.globalColors.panelBackground
     }
 
-    Box(
+    OutlinedButton(
+        onClick = onClick,
         modifier = Modifier
             .height(28.dp)
             .background(backgroundColor)
-            .padding(horizontal = 12.dp, vertical = 4.dp),
-        contentAlignment = Alignment.Center
+            .padding(horizontal = 4.dp, vertical = 2.dp)
     ) {
-        OutlinedButton(onClick = onClick) {
-            Text(
-                text = type.displayName,
-                style = JewelTheme.defaultTextStyle.copy(
-                    fontSize = 12.sp,
-                    fontWeight = if (isSelected) FontWeight.Bold else FontWeight.Normal
-                )
+        Text(
+            text = type.displayName,
+            style = JewelTheme.defaultTextStyle.copy(
+                fontSize = 12.sp,
+                fontWeight = if (isSelected) FontWeight.Bold else FontWeight.Normal
             )
-        }
+        )
     }
 }
 

mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentViewModel.kt

@@ -121,9 +121,18 @@ class IdeaAgentViewModel(
 
     /**
      * Abort the current request.
+     * Preserves partial streaming output if any.
      */
     fun abortRequest() {
         currentJob?.cancel()
+        // Preserve partial output if any
+        if (_streamingOutput.value.isNotEmpty()) {
+            val partialMessage = ModelChatMessage(
+                content = _streamingOutput.value + "\n\n[Interrupted]",
+                role = MessageRole.ASSISTANT
+            )
+            _messages.value = _messages.value + listOf(partialMessage)
+        }
         _isProcessing.value = false
         _streamingOutput.value = ""
     }