Enhance CI workflow and improve package consumption tests

- Updated the CI workflow to verify TypeScript types more effectively by removing unnecessary arguments.
- Improved ESM and CommonJS consumer tests to assert the correct types of imported functions, ensuring proper functionality of the Reflex library.
- Added error handling in the library packing functions to check for the existence of tarballs, enhancing reliability during the packaging process.
- Adjusted argument filtering in the main function to handle pnpm's argument parsing more accurately.

These changes aim to strengthen the testing framework and ensure robust package consumption.

Author: flexsurfer

.github/workflows/ci.yml

@@ -133,7 +133,7 @@ jobs:
 
       - name: Verify packed tarball (runtime smoke + TypeScript ${{ matrix.typescript }})
         run: >-
-          pnpm --filter @flexsurfer/reflex run test:types:legacy --
+          pnpm --filter @flexsurfer/reflex run test:types:legacy
           ${{ matrix.typescript }}
 
   test-matrix:
@@ -214,7 +214,13 @@ jobs:
           cd test-consumption/esm-consumer
           npm init -y
           npm install ../../reflex.tgz react@19.2.8
-          echo 'import { initState, dispatch } from "@flexsurfer/reflex"; console.log("ESM import works");' > test.mjs
+          cat > test.mjs <<'EOF'
+          import assert from 'node:assert/strict';
+          import { createReflexRuntime, useSubscription } from '@flexsurfer/reflex';
+          assert.equal(typeof createReflexRuntime, 'function');
+          assert.equal(typeof useSubscription, 'function');
+          console.log('ESM import works');
+          EOF
           node test.mjs
 
           # Test CommonJS consumption
@@ -223,7 +229,13 @@ jobs:
           cd cjs-consumer
           npm init -y
           npm install ../../reflex.tgz react@19.2.8
-          echo 'const { initState, dispatch } = require("@flexsurfer/reflex"); console.log("CommonJS require works");' > test.js
+          cat > test.js <<'EOF'
+          const assert = require('node:assert/strict');
+          const { createReflexRuntime, useSubscription } = require('@flexsurfer/reflex');
+          assert.equal(typeof createReflexRuntime, 'function');
+          assert.equal(typeof useSubscription, 'function');
+          console.log('CommonJS require works');
+          EOF
           node test.js
 
   devtools-workspaces:
@@ -382,8 +394,13 @@ jobs:
 
           # Create entry file that imports from the library
           cat > index.js << 'EOF'
-          import { initState } from "@flexsurfer/reflex";
-          console.log("Successfully imported initState:", typeof initState);
+          import { createReflexRuntime, useSubscription } from "@flexsurfer/reflex";
+          if (typeof createReflexRuntime !== "function") {
+            throw new Error("createReflexRuntime is not a function");
+          }
+          if (typeof useSubscription !== "function") {
+            throw new Error("useSubscription is not a function");
+          }
           console.log("Library bundled successfully!");
           EOF
 

packages/reflex-persist/tests/package-consumer/run.mjs

@@ -25,7 +25,11 @@ function pack(packageRoot, destination) {
   );
   const filename = JSON.parse(output)[0]?.filename;
   if (!filename) throw new Error(`npm pack did not report a tarball for ${packageRoot}.`);
-  return path.join(destination, filename);
+  const tarball = path.join(destination, filename);
+  if (!fs.existsSync(tarball)) {
+    throw new Error(`npm pack reported ${filename} for ${packageRoot} but wrote no tarball.`);
+  }
+  return tarball;
 }
 
 function compiler(name) {
@@ -49,6 +53,9 @@ function main() {
   try {
     process.env.npm_config_cache = path.join(workDir, '.npm-cache');
     process.env.npm_config_update_notifier = 'false';
+    // `npm publish --dry-run` exports npm_config_dry_run=true to lifecycle scripts, and
+    // prepublishOnly runs this check: without the override npm pack writes no tarball.
+    process.env.npm_config_dry_run = 'false';
     const reflexTarball = pack(reflexRoot, workDir);
     const persistTarball = pack(persistRoot, workDir);
     const consumerDir = path.join(workDir, 'consumer');

packages/reflex/tests/legacy-consumer/run.js

@@ -44,11 +44,18 @@ function packLibrary(destination, env) {
   if (!filename) {
     throw new Error('npm pack did not report a tarball filename.');
   }
-  return path.join(destination, filename);
+  const tarball = path.join(destination, filename);
+  if (!fs.existsSync(tarball)) {
+    throw new Error(`npm pack reported ${filename} but wrote no tarball.`);
+  }
+  return tarball;
 }
 
 function main() {
-  const requested = process.argv.slice(2).filter((version) => version.trim() !== '');
+  // pnpm forwards the `--` separator itself into argv, so drop it alongside blanks.
+  const requested = process.argv
+    .slice(2)
+    .filter((version) => version.trim() !== '' && version.trim() !== '--');
   const typescriptVersions = requested.length > 0 ? requested : DEFAULT_TYPESCRIPT_VERSIONS;
 
   if (!fs.existsSync(path.join(repoRoot, 'dist', 'index.mjs'))) {
@@ -59,6 +66,9 @@ function main() {
   const env = {
     ...process.env,
     npm_config_cache: path.join(workDir, 'npm-cache'),
+    // `npm publish --dry-run` exports npm_config_dry_run=true to lifecycle scripts, and
+    // prepublishOnly runs this check: without the override npm pack writes no tarball.
+    npm_config_dry_run: 'false',
   };
   try {
     const tarball = packLibrary(workDir, env);