chore(deps): downgrade tally from v4 to v3.5.8 (#224)

Align with go-code uberfx/tallyfx, which injects tally.Scope from
github.com/uber-go/tally rather than tally/v4.

## Why?
Currently, this repo uses tally/v4, but we use v3 internally. The
interface is the same but the types are not compatible.

## What?
Swap to version of tally used internally 

## Test Plan
- Tests in this repo
- Launch each of our internal services

Author: mnoah1

MODULE.bazel

@@ -53,7 +53,7 @@ use_repo(
     "com_github_go_sql_driver_mysql",
     "com_github_spf13_cobra",
     "com_github_stretchr_testify",
-    "com_github_uber_go_tally_v4",
+    "com_github_uber_go_tally",
     "in_gopkg_yaml_v3",
     "org_golang_google_grpc",
     "org_golang_google_grpc_cmd_protoc_gen_go_grpc",

core/metrics/BUILD.bazel

@@ -7,7 +7,7 @@ go_library(
     visibility = ["//visibility:public"],
     deps = [
         "//core/errs",
-        "@com_github_uber_go_tally_v4//:tally",
+        "@com_github_uber_go_tally//:tally",
     ],
 )
 
@@ -18,6 +18,6 @@ go_test(
     deps = [
         "//core/errs",
         "@com_github_stretchr_testify//assert",
-        "@com_github_uber_go_tally_v4//:tally",
+        "@com_github_uber_go_tally//:tally",
     ],
 )

core/metrics/metrics.go

@@ -17,7 +17,7 @@ package metrics
 import (
 	"time"
 
-	"github.com/uber-go/tally/v4"
+	"github.com/uber-go/tally"
 	"github.com/uber/submitqueue/core/errs"
 )
 

core/metrics/metrics_test.go

@@ -20,7 +20,7 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/uber-go/tally/v4"
+	"github.com/uber-go/tally"
 	"github.com/uber/submitqueue/core/errs"
 )
 

example/stovepipe/gateway/server/BUILD.bazel

@@ -13,7 +13,7 @@ go_library(
     deps = [
         "//stovepipe/gateway/controller",
         "//stovepipe/gateway/protopb",
-        "@com_github_uber_go_tally_v4//:tally",
+        "@com_github_uber_go_tally//:tally",
         "@org_golang_google_grpc//:grpc",
         "@org_golang_google_grpc//reflection",
         "@org_uber_go_zap//:zap",

example/stovepipe/gateway/server/main.go

@@ -25,7 +25,7 @@ import (
 	"syscall"
 	"time"
 
-	"github.com/uber-go/tally/v4"
+	"github.com/uber-go/tally"
 	"github.com/uber/submitqueue/stovepipe/gateway/controller"
 	pb "github.com/uber/submitqueue/stovepipe/gateway/protopb"
 	"go.uber.org/zap"

example/stovepipe/orchestrator/server/BUILD.bazel

@@ -13,7 +13,7 @@ go_library(
     deps = [
         "//stovepipe/orchestrator/controller",
         "//stovepipe/orchestrator/protopb",
-        "@com_github_uber_go_tally_v4//:tally",
+        "@com_github_uber_go_tally//:tally",
         "@org_golang_google_grpc//:grpc",
         "@org_golang_google_grpc//reflection",
         "@org_uber_go_zap//:zap",

example/stovepipe/orchestrator/server/main.go

@@ -25,7 +25,7 @@ import (
 	"syscall"
 	"time"
 
-	"github.com/uber-go/tally/v4"
+	"github.com/uber-go/tally"
 	"github.com/uber/submitqueue/stovepipe/orchestrator/controller"
 	pb "github.com/uber/submitqueue/stovepipe/orchestrator/protopb"
 	"go.uber.org/zap"

example/submitqueue/gateway/server/BUILD.bazel

@@ -24,7 +24,7 @@ go_library(
         "//submitqueue/gateway/controller/log",
         "//submitqueue/gateway/protopb",
         "@com_github_go_sql_driver_mysql//:mysql",
-        "@com_github_uber_go_tally_v4//:tally",
+        "@com_github_uber_go_tally//:tally",
         "@org_golang_google_grpc//:grpc",
         "@org_golang_google_grpc//codes",
         "@org_golang_google_grpc//reflection",

example/submitqueue/gateway/server/main.go

@@ -27,7 +27,7 @@ import (
 	"time"
 
 	_ "github.com/go-sql-driver/mysql"
-	"github.com/uber-go/tally/v4"
+	"github.com/uber-go/tally"
 	"github.com/uber/submitqueue/core/errs"
 	genericerrs "github.com/uber/submitqueue/core/errs/generic"
 	mysqlerrs "github.com/uber/submitqueue/core/errs/mysql"