Regression and dttr2 tests

Author: krlmlr

R/parse.R

@@ -28,6 +28,10 @@ parse_hm <- function(x) {
 }
 
 parse_time <- function(x, format) {
+  if (length(x) == 0) {
+    return(hms())
+  }
+
   parsed <- strptime(
     paste0("1970-01-01 ", as.character(x)),
     format = paste0("%Y-%m-%d ", format),

tests/testthat/test-parse.R

@@ -7,10 +7,13 @@ test_that("parse_hms", {
     as_hms(c(hms(56, 34, 12), hms(NA)))
   )
   expect_identical(parse_hms("23:59:59.999999999"), as_hms(86399.999999999))
+  expect_identical(parse_hms("24:00:00.999999999"), as_hms(86400.999999999))
+  expect_identical(parse_hms(character()), hms())
 })
 
 test_that("parse_hm", {
-  expect_equal(parse_hm("12:34"), hms(0, 34, 12))
-  expect_equal(parse_hm(NA), hms(NA))
-  expect_equal(parse_hm(c("12:34", NA)), as_hms(c(hms(0, 34, 12), hms(NA))))
+  expect_identical(parse_hm("12:34"), hms(0, 34, 12))
+  expect_identical(parse_hm(NA), hms(NA))
+  expect_identical(parse_hm(c("12:34", NA)), as_hms(c(hms(0, 34, 12), hms(NA))))
+  expect_identical(parse_hms(character()), hms())
 })