Fixes #39231 - Update webhooks table to use TableIndexPage#99
Fixes #39231 - Update webhooks table to use TableIndexPage#99Lukshio merged 6 commits intotheforeman:masterfrom
Conversation
Lukshio
left a comment
There was a problem hiding this comment.
First round of review. Overall it looks good, I would also delete all the foremanReact mocks and replace it with JSTestSetup import from foreman core.
I would also move the helper components directly to formatters, it does not make me much sense to have "Component" which just returns icon etc.
Tests looks good buy maybe the foreman test setup will break something, but it should be minor changes.
Lukshio
left a comment
There was a problem hiding this comment.
Thanks for the changes, I just found some new adjustments.
|
@pondrejk Changes looks good, I just found one last thing, please also remove this index file and replace the import https://github.com/pondrejk/foreman_webhooks/blob/2019a1c3d11330fa8d79dd4d10ec82f839a02a00/webpack/ForemanWebhooks/Routes/Webhooks/WebhooksIndexPage/index.js |
|
Tested by packit + manually |
|
Thanks @pondrejk |
SAT-44159
Removing pf3 table usage that will be deprecated in core in favor of TableIndexPage.
In fact TableIndexPage was already used in WebhooksIndexPage, but it wrapped WrappedWebhooksTable that wrapped WebhooksTable that wrapped WebhooksTableSchema. Here I'm flattening the structure with aim to rely mostly on what TableIndexPage provides.
I'm also moving some general table helpers to general components dir as they will be likely up for reuse when the webhook templates page gets converted from erb