feat(org-team): support notification_setting

Author: posquit0

modules/org-team/README.md

@@ -14,13 +14,13 @@ This module creates following resources.
 | Name | Version |
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.9 |
-| <a name="requirement_github"></a> [github](#requirement\_github) | >= 6.2 |
+| <a name="requirement_github"></a> [github](#requirement\_github) | >= 6.11 |
 
 ## Providers
 
 | Name | Version |
 |------|---------|
-| <a name="provider_github"></a> [github](#provider\_github) | 6.2.2 |
+| <a name="provider_github"></a> [github](#provider\_github) | 6.11.0 |
 
 ## Modules
 
@@ -42,23 +42,22 @@ No modules.
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | <a name="input_name"></a> [name](#input\_name) | (Required) The name of the team. | `string` | n/a | yes |
-| <a name="input_code_review_auto_assignment"></a> [code\_review\_auto\_assignment](#input\_code\_review\_auto\_assignment) | (Optional) A configuration for code review auto assignment. `code_review_auto_assignment` block as defined below.<br>    (Optional) `enabled` - Whether to enable code review auto assignment. Defaults to `false`.<br>    (Optional) `algorithm` - The algorithm to use for code review auto assignment. Valid values are `ROUND_ROBIN` or `LOAD_BALANCE`. Defaults to `ROUND_ROBIN`.<br>    (Optional) `assignment_count` - The number of reviewers to assign for each pull request.<br>    (Optional) `notify_team_enabled` - Whether to notify the entire team when both a team and one or more of its members are requested for review. Defaults to `false`. | <pre>object({<br>    enabled          = optional(bool, false)<br>    algorithm        = optional(string, "ROUND_ROBIN")<br>    assignment_count = optional(number)<br><br>    notify_team_enabled = optional(bool, false)<br>  })</pre> | `{}` | no |
-| <a name="input_default_maintainer_enabled"></a> [default\_maintainer\_enabled](#input\_default\_maintainer\_enabled) | (Optional) If true, adds the creating user as a default maintainer to the team. Defaults to `false`. | `bool` | `false` | no |
+| <a name="input_code_review_auto_assignment"></a> [code\_review\_auto\_assignment](#input\_code\_review\_auto\_assignment) | (Optional) A configuration for code review auto assignment. `code_review_auto_assignment` block as defined below.<br/>    (Optional) `enabled` - Whether to enable code review auto assignment. Defaults to `false`.<br/>    (Optional) `algorithm` - The algorithm to use for code review auto assignment. Valid values are `ROUND_ROBIN` or `LOAD_BALANCE`. Defaults to `ROUND_ROBIN`.<br/>    (Optional) `assignment_count` - The number of reviewers to assign for each pull request.<br/>    (Optional) `notify_team_enabled` - Whether to notify the entire team when both a team and one or more of its members are requested for review. Defaults to `false`. | <pre>object({<br/>    enabled          = optional(bool, false)<br/>    algorithm        = optional(string, "ROUND_ROBIN")<br/>    assignment_count = optional(number)<br/><br/>    notify_team_enabled = optional(bool, false)<br/>  })</pre> | `{}` | no |
 | <a name="input_description"></a> [description](#input\_description) | (Optional) A description of the team. | `string` | `"Managed by Terraform."` | no |
-| <a name="input_identity_provider_team_sync"></a> [identity\_provider\_team\_sync](#input\_identity\_provider\_team\_sync) | (Optional) A configuration to manage team members using your identity provider groups. `identity_provider_team_sync` block as defined below.<br>    (Optional) `enabled` - Whether to enable team synchronization between your identity provider (IdP) and your organization on GitHub. Defaults to `false`.<br>    (Optional) `groups` - A set of group names to sync with the team. | <pre>object({<br>    enabled = optional(bool, false)<br>    groups  = optional(set(string), [])<br>  })</pre> | `{}` | no |
+| <a name="input_identity_provider_team_sync"></a> [identity\_provider\_team\_sync](#input\_identity\_provider\_team\_sync) | (Optional) A configuration to manage team members using your identity provider groups. `identity_provider_team_sync` block as defined below.<br/>    (Optional) `enabled` - Whether to enable team synchronization between your identity provider (IdP) and your organization on GitHub. Defaults to `false`.<br/>    (Optional) `groups` - A set of group names to sync with the team. | <pre>object({<br/>    enabled = optional(bool, false)<br/>    groups  = optional(set(string), [])<br/>  })</pre> | `{}` | no |
 | <a name="input_is_secret"></a> [is\_secret](#input\_is\_secret) | (Optional) If true, team is only visible to the people on the team and people with owner permissions. Defaults to `false`. | `bool` | `false` | no |
 | <a name="input_ldap_group_dn"></a> [ldap\_group\_dn](#input\_ldap\_group\_dn) | (Optional) The LDAP Distinguished Name of the group where membership will be synchronized. Only available in GitHub Enterprise Server. | `string` | `null` | no |
 | <a name="input_maintainers"></a> [maintainers](#input\_maintainers) | (Optional) A list of usernames to add users as `maintainer` role. When applied, the user will become a maintainer of the team. | `set(string)` | `[]` | no |
 | <a name="input_members"></a> [members](#input\_members) | (Optional) A list of usernames to add users as `member` role. When applied, the user will become a member of the team. | `set(string)` | `[]` | no |
 | <a name="input_membership_sync_enabled"></a> [membership\_sync\_enabled](#input\_membership\_sync\_enabled) | (Optional) Whether to sync the members of the team. Members added outside of the Terraform code will be removed. Defaults to `false`. | `bool` | `false` | no |
+| <a name="input_notification_enabled"></a> [notification\_enabled](#input\_notification\_enabled) | (Optional) Whether to enable notifications for the team. Defaults to `true`. | `bool` | `true` | no |
 | <a name="input_parent_id"></a> [parent\_id](#input\_parent\_id) | (Optional) The ID of the parent team, if this is a nested team. | `string` | `null` | no |
 
 ## Outputs
 
 | Name | Description |
 |------|-------------|
 | <a name="output_code_review_auto_assignment"></a> [code\_review\_auto\_assignment](#output\_code\_review\_auto\_assignment) | A configuration for code review auto assignment. |
-| <a name="output_default_maintainer_enabled"></a> [default\_maintainer\_enabled](#output\_default\_maintainer\_enabled) | Whether to add the creating user as a default maintainer. |
 | <a name="output_description"></a> [description](#output\_description) | The description of the team. |
 | <a name="output_id"></a> [id](#output\_id) | The ID of the team. |
 | <a name="output_identity_provider_team_sync"></a> [identity\_provider\_team\_sync](#output\_identity\_provider\_team\_sync) | A configuration to manage team members using your identity provider groups. |
@@ -68,6 +67,7 @@ No modules.
 | <a name="output_members"></a> [members](#output\_members) | A list of the members of the team. |
 | <a name="output_name"></a> [name](#output\_name) | The name of the team. |
 | <a name="output_node_id"></a> [node\_id](#output\_node\_id) | The Node ID of the team. |
+| <a name="output_notification_enabled"></a> [notification\_enabled](#output\_notification\_enabled) | Whether notifications are enabled for the team. |
 | <a name="output_parent_id"></a> [parent\_id](#output\_parent\_id) | The ID of the parent team. |
 | <a name="output_slug"></a> [slug](#output\_slug) | The slug of the team. |
 <!-- END_TF_DOCS -->

modules/org-team/main.tf

@@ -1,14 +1,15 @@
 ###################################################
 # GitHub Organization Team
 ###################################################
-
+# INFO: Deprecated attributes
+# - `create_default_maintainer`
 resource "github_team" "this" {
-  name        = var.name
-  description = var.description
-  privacy     = var.is_secret ? "secret" : "closed"
+  name                 = var.name
+  description          = var.description
+  privacy              = var.is_secret ? "secret" : "closed"
+  notification_setting = var.notification_enabled ? "notifications_enabled" : "notifications_disabled"
 
-  parent_team_id            = var.parent_id
-  create_default_maintainer = var.default_maintainer_enabled
+  parent_team_id = var.parent_id
 
   ldap_dn = var.ldap_group_dn
 }

modules/org-team/outputs.tf

@@ -28,16 +28,16 @@ output "is_secret" {
   value       = var.is_secret
 }
 
+output "notification_enabled" {
+  description = "Whether notifications are enabled for the team."
+  value       = github_team.this.notification_setting == "notifications_enabled"
+}
+
 output "parent_id" {
   description = "The ID of the parent team."
   value       = github_team.this.parent_team_id
 }
 
-output "default_maintainer_enabled" {
-  description = "Whether to add the creating user as a default maintainer."
-  value       = github_team.this.create_default_maintainer
-}
-
 output "maintainers" {
   description = "A list of the maintainers of the team."
   value       = var.maintainers

modules/org-team/variables.tf

@@ -18,20 +18,20 @@ variable "is_secret" {
   nullable    = false
 }
 
+variable "notification_enabled" {
+  description = "(Optional) Whether to enable notifications for the team. Defaults to `true`."
+  type        = bool
+  default     = true
+  nullable    = false
+}
+
 variable "parent_id" {
   description = "(Optional) The ID of the parent team, if this is a nested team."
   type        = string
   default     = null
   nullable    = true
 }
 
-variable "default_maintainer_enabled" {
-  description = "(Optional) If true, adds the creating user as a default maintainer to the team. Defaults to `false`."
-  type        = bool
-  default     = false
-  nullable    = false
-}
-
 variable "maintainers" {
   description = "(Optional) A list of usernames to add users as `maintainer` role. When applied, the user will become a maintainer of the team."
   type        = set(string)

modules/org-team/versions.tf

@@ -4,7 +4,7 @@ terraform {
   required_providers {
     github = {
       source  = "integrations/github"
-      version = ">= 6.2"
+      version = ">= 6.11"
     }
   }
 }