Fix openssl build on Xcode 16.4+ - #3427
Closed
Kylmakalle wants to merge 1 commit into
Closed
Conversation
Kylmakalle
marked this pull request as draft
August 27, 2025 18:17
Kylmakalle
added a commit
to Swiftgram/TDLibFramework
that referenced
this pull request
Aug 27, 2025
Kylmakalle
marked this pull request as ready for review
August 27, 2025 18:21
Contributor
Author
|
I somehow missed #3364 entirely, will post my findings there |
Contributor
Author
|
re-opening, since #3364 breaks visionOS builds |
walkmn
approved these changes
Oct 2, 2025
Contributor
|
works great, thanks! |
MrMatras
approved these changes
Jan 16, 2026
scutuatua-crypto
approved these changes
Feb 18, 2026
bnnayaf12-lang
approved these changes
May 11, 2026
Contributor
|
Thank you, @Kylmakalle! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR alters the patch for simulator targets of openssl and fixes the build on Xcode 16.4+
Turns out TDLib's patch had an issue with duplicated
-simulatorsuffix that was ignored by clang of Xcode 16.0, but causes an issue with 16.4xcrun --sdk iphonesimulator clang -target x86_64-apple-ios-simulator-simulator -mios-simulator-version-min=12.0clang: error: version '-simulator' in target triple 'arm64-apple-ios-simulator-simulator' is invalidWhen running
make vars-iOS-simulator, I was able to spot an exact issue withTARGET_TRIPLE