Starting FastAPI 0.94.0 startup / shutdown events are decpricated

[quizmoon]

Starting of FastAPI 0.94.0 the "startup / shutdown" events are deprecated and the "lifespan" has been introduced:
https://fastapi.tiangolo.com/advanced/events/#lifespan

Would be great to have support of "lifespan" in taskiq-fastapi or example how to avoid duplication of startup / shutdown calls.

[s3rius]

Hi and thanks for noticing.

The startup|shutdown are not yet deprecated. We will use them untill it's deprecated, because it works. If it won't, we implement it.

[quizmoon]

Well, it is not removed, but deprecated:
Alternative Events (deprecated)

[s3rius]

🤔 🤔 🤔 Okay. Probably it would be nice to implement.

[XChikuX]

@s3rius Is the below method acceptable?

I think we need some updated docs

@asynccontextmanager
async def lifespan(app: FastAPI):
    # Load the FastAPI app
    log.info("[bold green blink]App is Starting Up![/]", extra={"markup": True})
    if not broker.is_worker_process:
        log.info("Starting TaskIQ broker")
        await broker.startup()
    yield

    log.info(
        "[bold blue blink]App is Shutting Down Gracefully![/]",
        extra={"markup": True},
    )
    if not broker.is_worker_process:
        log.info("Shutting down TaskIQ broker")
        await broker.shutdown()


app = FastAPI(title="❤️", lifespan=lifespan)

[s3rius]

Sure thing.

[Maksim75ru]

maybe the time has come?

[XChikuX]

I'd drop the maybe.. ;)