Import completion truncates package names

[dsl101]

Apologies if this is actually an LSP issue rather than ST-specific; searching online didn't turn up anything obvious on either side. I'm attempting to import 'something' from, e.g., the firebase sdk:

import {} from 'fire

I get that far, and see completions such as:

I can 'tab' to select, 2 levels deep. I can get as far as this:

And at that point, if I select anything in that dropdown, I end up with something like this:

import {} from 'v2/core'

The initial part of the import is missing. This happens even if there is only 1 slash in the filter to begin with. E.g. this:

results in:

import {} from 'v1/auth

Is this an issue with LSP-typescript, or something unrelated?

[predragnikolic]

Here is a zip with that can reproduce the bug.

firebase.zip

Seems like a bug in the language server.

if I have a file import {} from 'firebase-functions/v2/'
the language server does seem to return the wrong TextEdit start character value.
It returned 16 but it should be 36.

:: [19:05:32.864] <<< LSP-typescript (48) (duration: 16ms): {'items': [{'label': 'v2/core', 'kind': 17, 'sortText': '11', 'data': {'cacheId': 1}, 'textEdit': {'range': {'start': {'line': 0, 'character': 16}, 'end': {'line': 0, 'character': 38}}, 'newText': 'v2/core'}}

[rchl]

It looks to me like in vscode those completions are filtered out on the generic completions handling level since I haven't found any code in their typescript-language-features that would do that and I still see those in tsserver response...

[rchl]

Yep, it's VSCode's completions handling that filters those out.

I have not tried to understand fully what is it doing but it's this line specifically:

https://github.com/microsoft/vscode/blob/6b924c51528e663dda5091a1493229a361676aca/src/vs/editor/contrib/suggest/browser/completionModel.ts#L218-L219

and I would guess that since it considers this completion to match from before the completion start (the start of firebase-functions/) then it expects that it matches against it and since it doesn't, it's filtered out. Or something like this.

I'm not sure this logic really belongs in the server. Ideally typescript (tsserver) would just not return those.

The state of variables in this case is as below (for alerts/appDistribution completion which has the same issue):

const word = "firebase-functions/"
const wordLow = "firebase-functions/"
cons wordPos = 0
const item = {
    "position": {
        "lineNumber": 1,
        "column": 36
    },
    "completion": {
        "label": "alerts/appDistribution",
        "extensionId": {
            "value": "vscode.typescript-language-features",
            "_lower": "vscode.typescript-language-features"
        },
        "kind": 20,
        "sortText": "11",
        "insertText": "alerts/appDistribution",
        "range": {
            "insert": {
                "startLineNumber": 1,
                "startColumn": 17,
                "endLineNumber": 1,
                "endColumn": 36
            },
            "replace": {
                "startLineNumber": 1,
                "startColumn": 17,
                "endLineNumber": 1,
                "endColumn": 36
            }
        },
        "insertTextRules": 0,
        "command": {
            "$ident": "_typescript.applyCompletionCommand /272",
            "id": "__vsca39c8007-7194-4675-b6dc-fef0db017f6a",
            "title": "",
            "arguments": [
                "_typescript.applyCompletionCommand /272"
            ]
        },
        "_id": [
            4,
            21
        ]
    },
    "isInvalid": false,
    "score": [
        -100,
        0
    ],
    "distance": 0,
    "textLabel": "alerts/appDistribution",
    "labelLow": "alerts/appdistribution",
    "sortTextLow": "11",
    "editStart": {
        "lineNumber": 1,
        "column": 17
    },
    "editInsertEnd": {
        "lineNumber": 1,
        "column": 36
    },
    "editReplaceEnd": {
        "lineNumber": 1,
        "column": 36
    },
    "word": "firebase-functions/"
}

[predragnikolic]

I do see this as a bug of the tsserver itself.
The range insert start column is not correct.
I do have a theory. The completion is invoked in a place where you usually need to write module name.
Maybe the ts server is confused, and incorrectly thinks that "alerts/appDistribution" is a module name, thus it replaces the whole module string.

If I select v1 and v2 completion items, those are inserted correctly.

[predragnikolic]

Here is the tsserver response:

tsserver-response.json

Only the completion that don't have a replacementSpan specified are shown in vs code,
and only those completions can be correctly inserted when selected in SublimeText.

[rchl]

Here is the tsserver response:

tsserver-response.json

Only the completion that don't have a replacementSpan specified are shown in vs code, and only those completions can be correctly inserted when selected in SublimeText.

Yep, though it's not that presence of replacementSpan itself is the problem. The problem is that replacementSpan start column points back from where the completion starts. In vscode this case is called overwriteBefore (replace range).