Skip to content

chore: fix JavaScript lint errors#12257

Merged
kgryte merged 4 commits into
stdlib-js:developfrom
nathanaelmbale:fix-javascript-lint-errors-12236
May 24, 2026
Merged

chore: fix JavaScript lint errors#12257
kgryte merged 4 commits into
stdlib-js:developfrom
nathanaelmbale:fix-javascript-lint-errors-12236

Conversation

@nathanaelmbale
Copy link
Copy Markdown
Contributor

Resolves #12236

Description

What is the purpose of this pull request?

This pull request:

  • Removes an unexpected empty line between require statements in @stdlib/blas/base/ssyr/test/test.ndarray.js
  • Replaces new Array() constructor usage with zeros( arguments.length+1, 'generic' ) in @stdlib/plot/components/svg/defs/lib/main.js to comply with the stdlib/no-new-array lint rule

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

No disclosure


@stdlib-js/reviewers

](chore: fix JavaScript lint errors issue #12236)

@nathanaelmbale nathanaelmbale requested a review from a team May 23, 2026 20:25
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels May 23, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 23, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/base/ssyr $\color{green}616/616$
$\color{green}+0.00%$
$\color{green}82/82$
$\color{green}+0.00%$
$\color{green}5/5$
$\color{green}+0.00%$
$\color{green}616/616$
$\color{green}+0.00%$
plot/components/svg/defs $\color{green}217/217$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}217/217$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@nathanaelmbale nathanaelmbale changed the title Fix javascript lint errors 12236 chore: fix JavaScript lint errors (issue #12236) May 24, 2026
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label May 24, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 3 and removed Needs Review A pull request which needs code review. labels May 24, 2026
@kgryte kgryte changed the title chore: fix JavaScript lint errors (issue #12236) chore: fix JavaScript lint errors May 24, 2026
@kgryte kgryte merged commit 40dad68 into stdlib-js:develop May 24, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants