Skip to content

chore: added zizmor to GH Actions ci workflow#166

Merged
tomayac merged 5 commits into
sqlite:mainfrom
jurerotar:chore/zizmor
May 22, 2026
Merged

chore: added zizmor to GH Actions ci workflow#166
tomayac merged 5 commits into
sqlite:mainfrom
jurerotar:chore/zizmor

Conversation

@jurerotar
Copy link
Copy Markdown
Contributor

Another safety-oriented PR. Zizmor is essentially a linter for GH Actions, if we add any funky settings to them in the future, they should be flagged with this.

https://github.com/zizmorcore/zizmor

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/ci.yml Fixed
@jurerotar
Copy link
Copy Markdown
Contributor Author

Ah, it seems we're already doing it, I wasn't aware. I'll close this PR then 😄

@jurerotar jurerotar closed this May 19, 2026
@tomayac
Copy link
Copy Markdown
Collaborator

tomayac commented May 19, 2026

Perfect, still thanks for the double check.

@jurerotar jurerotar reopened this May 22, 2026
@jurerotar
Copy link
Copy Markdown
Contributor Author

jurerotar commented May 22, 2026

I've decided to re-open this PR. My logic goes that if at any point this additional check that I didn't know about gets turned off, we still have our own version of it 😄

Edit: I've also pinned all actions to their exact commits. When we need to update, we can use https://github.com/suzuki-shunsuke/pinact#update-actions--update

Comment thread .github/workflows/publish.yml Fixed
Comment thread .github/workflows/build-wasm.yml Fixed
Comment thread .github/workflows/ci.yml
name: Zizmor GitHub Actions check
runs-on: ubuntu-latest
permissions:
actions: read
Copy link
Copy Markdown
Collaborator

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomayac tomayac merged commit 00f6598 into sqlite:main May 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants