Fix codon inclusion check on SSE/neon for more than 4 start codons

milot-mirdita · Eulium · milot-mirdita · commit 11933403321b · 2026-05-29T16:10:45.000+09:00
Co-authored-by: Patrick Boppert &lt;pboppert@snu.ac.kr&gt;
diff --git a/src/commons/Orf.cpp b/src/commons/Orf.cpp
@@ -219,7 +219,7 @@ inline bool isInCodons(const char* sequence, simd_int codons, simd_int) {
 #ifndef AVX2
     if (N > 4) {
         simd_int test2 = simdi32_eq(c, codons2);
-        return (simdi8_movemask(test) != 0) && (simdi8_movemask(test2) != 0);
+        return (simdi8_movemask(test) != 0) || (simdi8_movemask(test2) != 0);
     }
 #endif
     return simdi8_movemask(test) != 0;

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ inline bool isInCodons(const char* sequence, simd_int codons, simd_int) {`
`219`	`219`	`#ifndef AVX2`
`220`	`220`	`if (N > 4) {`
`221`	`221`	`simd_int test2 = simdi32_eq(c, codons2);`
`222`		`- return (simdi8_movemask(test) != 0) && (simdi8_movemask(test2) != 0);`
	`222`	`+ return (simdi8_movemask(test) != 0) \|\| (simdi8_movemask(test2) != 0);`
`223`	`223`	`}`
`224`	`224`	`#endif`
`225`	`225`	`return simdi8_movemask(test) != 0;`