Skip to content

Bumping tokio dependencies in patches makes it hard to avoid breakage #4567

@sarsko

Description

@sarsko

Hi there,

From version 1.11.4 to 1.11.5 aws_smithy_runtime_api went from tokio version 1.46 to 1.49. Unfortunately tokio unstable'd Dump from version 1.47 to 1.48 (https://docs.rs/tokio/1.47.0/tokio/runtime/dump/struct.Dump.html, https://docs.rs/tokio/1.48.0/tokio/runtime/dump/struct.Dump.html), which meant that upgrading to 1.11.5 became breaking for crates that used Dump.

I see that since then, aws_smithy_runtime_api has again upgraded to tokio 1.50 in 1.11.6

I have two questions:

  1. Why is aws_smithy_runtime_api bumping tokio version? My view is that aws_smithy_runtime_api is a library and should depend on as low of a version as possible. If the stance is that "customers should keep their tokio version up to date" (or similar) then I don't think the requirement should be any higher than the current LTS version, which was tokio 1.43 and 1.47 until March, and tokio 1.47 currently.
  2. If bumping dependencies is something you need to do, can you at least do it with a minor bump so that it is possible to not break the build without pinning the dependencies.

Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions