Skip to content

Commit 0a4265c

Browse files
committed
Update relevant Java test classes.
1 parent 952be9b commit 0a4265c

File tree

2 files changed

+50
-0
lines changed

2 files changed

+50
-0
lines changed

slack-api-client/src/test/java/test_locally/api/methods/UsergroupsTest.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@
77
import org.junit.Test;
88
import util.MockSlackApiServer;
99

10+
import java.util.stream.Collectors;
11+
import java.util.stream.Stream;
12+
1013
import static org.hamcrest.CoreMatchers.is;
1114
import static org.hamcrest.MatcherAssert.assertThat;
1215
import static util.MockSlackApi.ValidToken;
@@ -44,6 +47,10 @@ public void test() throws Exception {
4447
.isOk(), is(true));
4548
assertThat(slack.methods(ValidToken).usergroupsUsersUpdate(r -> r.usergroup("xxx"))
4649
.isOk(), is(true));
50+
assertThat(slack.methods(ValidToken).usergroupsUsersUpdate(r -> r.usergroup("xxx").users(Stream.<String>of().collect(Collectors.toList())))
51+
.isOk(), is(true));
52+
assertThat(slack.methods(ValidToken).usergroupsUsersUpdate(r -> r.usergroup("xxx").users(Stream.of("user").collect(Collectors.toList())))
53+
.isOk(), is(true));
4754
}
4855

4956
@Test
@@ -62,6 +69,10 @@ public void test_async() throws Exception {
6269
.get().isOk(), is(true));
6370
assertThat(slack.methodsAsync(ValidToken).usergroupsUsersUpdate(r -> r.usergroup("xxx"))
6471
.get().isOk(), is(true));
72+
assertThat(slack.methodsAsync(ValidToken).usergroupsUsersUpdate(r -> r.usergroup("xxx").users(Stream.<String>of().collect(Collectors.toList())))
73+
.get().isOk(), is(true));
74+
assertThat(slack.methodsAsync(ValidToken).usergroupsUsersUpdate(r -> r.usergroup("xxx").users(Stream.of("user").collect(Collectors.toList())))
75+
.get().isOk(), is(true));
6576
}
6677

6778
}

slack-api-client/src/test/java/test_with_remote_apis/methods/usergroups_Test.java

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.slack.api.Slack;
44
import com.slack.api.methods.request.usergroups.users.UsergroupsUsersListRequest;
5+
import com.slack.api.methods.request.usergroups.users.UsergroupsUsersUpdateRequest;
56
import com.slack.api.methods.response.usergroups.*;
67
import com.slack.api.methods.response.usergroups.users.UsergroupsUsersListResponse;
78
import com.slack.api.methods.response.usergroups.users.UsergroupsUsersUpdateResponse;
@@ -17,6 +18,8 @@
1718

1819
import java.util.ArrayList;
1920
import java.util.List;
21+
import java.util.stream.Collectors;
22+
import java.util.stream.Stream;
2023

2124
import static org.hamcrest.CoreMatchers.*;
2225
import static org.hamcrest.MatcherAssert.assertThat;
@@ -147,4 +150,40 @@ public void users_failure() throws Exception {
147150
assertThat(response.getError(), is("no_such_subteam"));
148151
}
149152

153+
@Test
154+
public void usergroups_users_update_null_property() throws Exception {
155+
UsergroupsCreateResponse creation = slack.methods().usergroupsCreate(r -> r
156+
.token(userToken)
157+
.name("usergroup-" + System.currentTimeMillis())
158+
.description("Something wrong"));
159+
assertThat(creation.getError(), is(nullValue()));
160+
final Usergroup usergroup = creation.getUsergroup();
161+
162+
UsergroupsUsersUpdateResponse response = slack.methods().usergroupsUsersUpdate(
163+
UsergroupsUsersUpdateRequest.builder()
164+
.token(userToken)
165+
.usergroup(usergroup.getId())
166+
.build());
167+
assertThat(response.isOk(), is(false));
168+
assertThat(response.getError(), is("missing_required_argument"));
169+
}
170+
171+
@Test
172+
public void usergroups_users_update_empty_list() throws Exception {
173+
UsergroupsCreateResponse creation = slack.methods().usergroupsCreate(r -> r
174+
.token(userToken)
175+
.name("usergroup-" + System.currentTimeMillis())
176+
.description("Should have 0 members"));
177+
assertThat(creation.getError(), is(nullValue()));
178+
final Usergroup usergroup = creation.getUsergroup();
179+
180+
UsergroupsUsersUpdateResponse response = slack.methods().usergroupsUsersUpdate(
181+
UsergroupsUsersUpdateRequest.builder()
182+
.token(userToken)
183+
.usergroup(usergroup.getId())
184+
.users(Stream.<String>of().collect(Collectors.toList()))
185+
.build());
186+
assertThat(response.getError(), is(nullValue()));
187+
}
188+
150189
}

0 commit comments

Comments
 (0)