Skip to content

Commit 08e087f

Browse files
committed
🔧 fix: #291
Signed-off-by: shub39 <cptnshubham39@gmail.com>
1 parent 06e43e0 commit 08e087f

2 files changed

Lines changed: 71 additions & 59 deletions

File tree

shared/src/commonMain/kotlin/com/shub39/grit/core/habits/presentation/ui/component/HabitUpsertSheet.kt

Lines changed: 28 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ fun HabitUpsertSheetContent(
270270
},
271271
enabled =
272272
!(newHabit.days.size == 1 &&
273-
newHabit.days.contains(dayOfWeek)),
273+
newHabit.days.contains(dayOfWeek)),
274274
modifier = Modifier.weight(1f),
275275
colors = ToggleButtonDefaults.tonalToggleButtonColors(),
276276
content = { Text(text = dayOfWeek.name.take(1)) },
@@ -348,25 +348,35 @@ fun HabitUpsertSheetContent(
348348
}
349349
}
350350
}
351-
}
352351

353-
Button(
354-
onClick = {
355-
onUpsertHabit(
356-
newHabit.copy(
357-
title = titleTextFieldState.text.toString(),
358-
description = descTextFieldState.text.toString(),
352+
item {
353+
Button(
354+
onClick = {
355+
onUpsertHabit(
356+
newHabit.copy(
357+
title = titleTextFieldState.text.toString(),
358+
description = descTextFieldState.text.toString(),
359+
)
360+
)
361+
onDismissRequest()
362+
},
363+
modifier = Modifier.padding(bottom = 32.dp).fillMaxWidth(),
364+
enabled =
365+
descTextFieldState.text.length <= 50 &&
366+
titleTextFieldState.text.length <= 20 &&
367+
titleTextFieldState.text.isNotBlank(),
368+
) {
369+
Text(
370+
text = stringResource(
371+
if (isEditSheet) {
372+
Res.string.save
373+
} else {
374+
Res.string.add_habit
375+
}
376+
)
359377
)
360-
)
361-
onDismissRequest()
362-
},
363-
modifier = Modifier.padding(start = 16.dp, end = 16.dp, bottom = 32.dp).fillMaxWidth(),
364-
enabled =
365-
descTextFieldState.text.length <= 50 &&
366-
titleTextFieldState.text.length <= 20 &&
367-
titleTextFieldState.text.isNotBlank(),
368-
) {
369-
Text(text = stringResource(if (isEditSheet) Res.string.save else Res.string.add_habit))
378+
}
379+
}
370380
}
371381

372382
if (timePickerDialog) {

shared/src/commonMain/kotlin/com/shub39/grit/core/tasks/presentation/ui/component/TaskUpsertSheet.kt

Lines changed: 43 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -247,50 +247,52 @@ fun TaskUpsertSheetContent(
247247
},
248248
)
249249
}
250-
}
251250

252-
Column(
253-
horizontalAlignment = Alignment.CenterHorizontally,
254-
verticalArrangement = Arrangement.spacedBy(8.dp),
255-
) {
256-
Row(
257-
modifier = Modifier.padding(start = 16.dp, end = 16.dp, bottom = 32.dp),
258-
horizontalArrangement = Arrangement.spacedBy(8.dp),
259-
) {
260-
if (isEditSheet) {
261-
OutlinedButton(
262-
onClick = onDelete,
263-
shapes =
264-
ButtonShapes(
265-
shape = MaterialTheme.shapes.extraLarge,
266-
pressedShape = MaterialTheme.shapes.small,
267-
),
268-
modifier = Modifier.weight(1f),
251+
item {
252+
Column(
253+
horizontalAlignment = Alignment.CenterHorizontally,
254+
verticalArrangement = Arrangement.spacedBy(8.dp),
255+
) {
256+
Row(
257+
modifier = Modifier.padding(bottom = 32.dp),
258+
horizontalArrangement = Arrangement.spacedBy(8.dp),
269259
) {
270-
Text(stringResource(Res.string.delete))
271-
}
272-
}
260+
if (isEditSheet) {
261+
OutlinedButton(
262+
onClick = onDelete,
263+
shapes =
264+
ButtonShapes(
265+
shape = MaterialTheme.shapes.extraLarge,
266+
pressedShape = MaterialTheme.shapes.small,
267+
),
268+
modifier = Modifier.weight(1f),
269+
) {
270+
Text(stringResource(Res.string.delete))
271+
}
272+
}
273273

274-
Button(
275-
onClick = {
276-
onUpsert(newTask.copy(title = textFieldState.text.toString()))
277-
onDismissRequest()
278-
},
279-
shapes =
280-
ButtonShapes(
281-
shape = MaterialTheme.shapes.extraLarge,
282-
pressedShape = MaterialTheme.shapes.small,
283-
),
284-
modifier = Modifier.weight(1f),
285-
enabled =
286-
textFieldState.text.isNotBlank() &&
287-
textFieldState.text.length <= 100 &&
288-
isValidDateTime &&
289-
(newTask.reminder != task.reminder ||
290-
textFieldState.text.toString() != task.title ||
291-
newTask.categoryId != task.categoryId),
292-
) {
293-
Text(stringResource(if (isEditSheet) Res.string.save else Res.string.add_task))
274+
Button(
275+
onClick = {
276+
onUpsert(newTask.copy(title = textFieldState.text.toString()))
277+
onDismissRequest()
278+
},
279+
shapes =
280+
ButtonShapes(
281+
shape = MaterialTheme.shapes.extraLarge,
282+
pressedShape = MaterialTheme.shapes.small,
283+
),
284+
modifier = Modifier.weight(1f),
285+
enabled =
286+
textFieldState.text.isNotBlank() &&
287+
textFieldState.text.length <= 100 &&
288+
isValidDateTime &&
289+
(newTask.reminder != task.reminder ||
290+
textFieldState.text.toString() != task.title ||
291+
newTask.categoryId != task.categoryId),
292+
) {
293+
Text(stringResource(if (isEditSheet) Res.string.save else Res.string.add_task))
294+
}
295+
}
294296
}
295297
}
296298
}

0 commit comments

Comments
 (0)