fix: Add drop task initial connect retry (#45)

Drop task can "see" server in crashed state in recovery tests during
initial connect.
This PR add retries so drop task will wait until server comes up in
unlucky case.

Author: Dronplane

sqllogictest-bin/src/main.rs

@@ -850,7 +850,31 @@ async fn drop_task(
 ) -> Result<()> {
     const MAX_RETRIES: usize = 1;
     const RETRY_DELAY: Duration = Duration::from_secs(1);
-    let mut db = engines::connect(&engine, &config, SslMode::Disable, DBPort::Plain).await?;
+    // Recovery tests intentionally crash the server, and the
+    // dropper's startup connect runs concurrently with the test -- it can be in
+    // flight when that crash kills the server, surfacing as a one-off
+    // "connection closed".
+    // CONNECT_RETRIES is deliberately much larger than MAX_RETRIES because the
+    // two cover different situations. The DROP runs *after* the test, when the
+    // server is already back up. This
+    // connect can instead land *during* the crash/restart window, when the
+    // server is genuinely down, so it must keep trying long enough to outlast a
+    // full restart -- many more attempts than reconnecting to an already-up
+    // server.
+    const CONNECT_RETRIES: usize = 10;
+    let mut connect_attempts = 0;
+    let mut db = loop {
+        match engines::connect(&engine, &config, SslMode::Disable, DBPort::Plain).await {
+            Ok(conn) => break conn,
+            Err(e) => {
+                connect_attempts += 1;
+                if connect_attempts > CONNECT_RETRIES {
+                    return Err(e.into());
+                }
+                tokio::time::sleep(RETRY_DELAY).await;
+            }
+        }
+    };
 
     while let Some(message) = drop_rx.recv().await {
         match message {

sqllogictest-engines/src/postgres/extended.rs

@@ -244,7 +244,9 @@ impl<'a> FromSql<'a> for TimestampValue {
                 return Ok(TimestampValue("-infinity".into()));
             }
         }
-        Ok(TimestampValue(NaiveDateTime::from_sql(ty, raw)?.to_string()))
+        Ok(TimestampValue(
+            NaiveDateTime::from_sql(ty, raw)?.to_string(),
+        ))
     }
 
     accepts!(TIMESTAMP);

sqllogictest/src/substitution.rs

@@ -44,9 +44,7 @@ fn escape_bare_dollars(input: &str) -> String {
     let mut out = String::with_capacity(input.len());
     let mut chars = input.chars().peekable();
     while let Some(c) = chars.next() {
-        if c == '$'
-            && !matches!(chars.peek(), Some(&('{' | 'a'..='z' | 'A'..='Z' | '_')))
-        {
+        if c == '$' && !matches!(chars.peek(), Some(&('{' | 'a'..='z' | 'A'..='Z' | '_'))) {
             out.push('\\');
         }
         out.push(c);