fix(dev): handly clippy warnings in benches and make CI Docker cache more resilient

Author: azasypkin

.github/workflows/ci.yml

@@ -204,13 +204,13 @@ jobs:
           load: true
           set: |
             retrack.cache-from=type=gha,scope=retrack
-            retrack.cache-to=type=gha,mode=max,scope=retrack
+            retrack.cache-to=type=gha,mode=max,scope=retrack,ignore-error=true
             retrack_web_scraper.cache-from=type=gha,scope=retrack-web-scraper
-            retrack_web_scraper.cache-to=type=gha,mode=max,scope=retrack-web-scraper
+            retrack_web_scraper.cache-to=type=gha,mode=max,scope=retrack-web-scraper,ignore-error=true
             secutils_api.cache-from=type=gha,scope=secutils-api
-            secutils_api.cache-to=type=gha,mode=max,scope=secutils-api
+            secutils_api.cache-to=type=gha,mode=max,scope=secutils-api,ignore-error=true
             secutils_webui.cache-from=type=gha,scope=secutils-webui
-            secutils_webui.cache-to=type=gha,mode=max,scope=secutils-webui
+            secutils_webui.cache-to=type=gha,mode=max,scope=secutils-webui,ignore-error=true
 
       - name: Save Docker images
         run: >

benches/js-runtime-perf/src/report.rs

@@ -118,10 +118,10 @@ fn detect_cpu_model() -> String {
     #[cfg(target_os = "linux")]
     if let Ok(contents) = fs::read_to_string("/proc/cpuinfo") {
         for line in contents.lines() {
-            if let Some(rest) = line.strip_prefix("model name") {
-                if let Some(idx) = rest.find(':') {
-                    return rest[idx + 1..].trim().to_string();
-                }
+            if let Some(rest) = line.strip_prefix("model name")
+                && let Some(idx) = rest.find(':')
+            {
+                return rest[idx + 1..].trim().to_string();
             }
         }
     }

src/search/search_index.rs

@@ -527,14 +527,14 @@ mod tests {
         index.upsert(&public_item)?;
 
         let mut public_items = index.search(SearchFilter::default())?;
-        public_items.sort_by(|item_a, item_b| item_a.id.cmp(&item_b.id));
+        public_items.sort_by_key(|item| item.id);
         assert_eq!(public_items, vec![public_item.clone()]);
 
         let mut public_and_user_items = index.search(
             SearchFilter::default()
                 .with_user_id(uuid!("00000000-0000-0000-0000-000000000003").into()),
         )?;
-        public_and_user_items.sort_by(|item_a, item_b| item_a.id.cmp(&item_b.id));
+        public_and_user_items.sort_by_key(|item| item.id);
         assert_eq!(
             public_and_user_items,
             vec![item_user_3, public_item.clone()]
@@ -544,7 +544,7 @@ mod tests {
             SearchFilter::default()
                 .with_user_id(uuid!("00000000-0000-0000-0000-000000000004").into()),
         )?;
-        public_and_user_items.sort_by(|item_a, item_b| item_a.id.cmp(&item_b.id));
+        public_and_user_items.sort_by_key(|item_a| item_a.id);
         assert_eq!(
             public_and_user_items,
             vec![item_user_4, public_item.clone()]
@@ -585,7 +585,7 @@ mod tests {
         index.upsert(&item_2)?;
 
         let mut items = index.search(SearchFilter::default())?;
-        items.sort_by(|item_a, item_b| item_a.id.cmp(&item_b.id));
+        items.sort_by_key(|item_a| item_a.id);
         assert_eq!(items, vec![item_1.clone(), item_2.clone()]);
 
         index.remove(item_1.id)?;