fix(db): drop startup backfill per review (finos#1656)

Remove backfillRepoDates and startup hooks; existing-repo migration
will follow in a separate PR with a versioned migration framework.

Author: sankalpsthakur

src/db/file/index.ts

@@ -33,7 +33,6 @@ export const {
   addUserCanAuthorise,
   removeUserCanPush,
   removeUserCanAuthorise,
-  backfillRepoDates,
   deleteRepo,
 } = repo;
 

src/db/file/repo.ts

@@ -230,48 +230,6 @@ export const removeUserCanPush = async (_id: string, user: string): Promise<void
   });
 };
 
-/**
- * Backfill missing dateCreated/lastModified on existing NeDB repos.
- * Idempotent: only updates docs missing either field. Called from adaptor init.
- */
-export const backfillRepoDates = async (
-  fallbackIso = new Date(0).toISOString(),
-): Promise<number> => {
-  return new Promise<number>((resolve, reject) => {
-    db.find(
-      { $or: [{ dateCreated: { $exists: false } }, { lastModified: { $exists: false } }] },
-      (err: Error | null, docs: Repo[]) => {
-        /* istanbul ignore if */
-        if (err) {
-          reject(err);
-          return;
-        }
-        let updated = 0;
-        const pending = docs.length;
-        if (pending === 0) {
-          resolve(0);
-          return;
-        }
-        docs.forEach((doc) => {
-          const patch = {
-            dateCreated: doc.dateCreated ?? fallbackIso,
-            lastModified: doc.lastModified ?? doc.dateCreated ?? fallbackIso,
-          };
-          db.update({ _id: doc._id }, { $set: patch }, {}, (updateErr) => {
-            /* istanbul ignore if */
-            if (updateErr) {
-              reject(updateErr);
-              return;
-            }
-            updated += 1;
-            if (updated === pending) resolve(updated);
-          });
-        });
-      },
-    );
-  });
-};
-
 export const deleteRepo = async (_id: string): Promise<void> => {
   return new Promise<void>((resolve, reject) => {
     db.remove({ _id: _id }, (err) => {

src/db/index.ts

@@ -37,17 +37,10 @@ const start = () => {
     if (config.getDatabase().type === 'mongo') {
       console.log('Loading MongoDB database adaptor');
       _sink = mongo;
-      // #1486: idempotent backfill for existing repos missing date fields
-      void mongo.backfillRepoDates().then((n) => {
-        if (n > 0) console.log(`Backfilled dateCreated/lastModified on ${n} repo(s)`);
-      });
     } else if (config.getDatabase().type === 'fs') {
       console.log('Loading neDB database adaptor');
       initializeFolders();
       _sink = neDb;
-      void neDb.backfillRepoDates().then((n) => {
-        if (n > 0) console.log(`Backfilled dateCreated/lastModified on ${n} repo(s)`);
-      });
     } else {
       console.error(`Unsupported database type: ${config.getDatabase().type}`);
       process.exit(1);

src/db/mongo/index.ts

@@ -33,7 +33,6 @@ export const {
   addUserCanAuthorise,
   removeUserCanPush,
   removeUserCanAuthorise,
-  backfillRepoDates,
   deleteRepo,
 } = repo;
 

src/db/mongo/repo.ts

@@ -96,32 +96,6 @@ export const removeUserCanAuthorise = async (_id: string, user: string): Promise
   );
 };
 
-/**
- * Backfill missing dateCreated/lastModified on existing Mongo repos.
- * Idempotent; safe to run on every startup.
- */
-export const backfillRepoDates = async (
-  fallbackIso = new Date(0).toISOString(),
-): Promise<number> => {
-  const collection = await connect(collectionName);
-  const result = await collection.updateMany(
-    {
-      $or: [{ dateCreated: { $exists: false } }, { lastModified: { $exists: false } }],
-    },
-    [
-      {
-        $set: {
-          dateCreated: { $ifNull: ['$dateCreated', fallbackIso] },
-          lastModified: {
-            $ifNull: ['$lastModified', { $ifNull: ['$dateCreated', fallbackIso] }],
-          },
-        },
-      },
-    ],
-  );
-  return result.modifiedCount;
-};
-
 export const deleteRepo = async (_id: string): Promise<void> => {
   const collection = await connect(collectionName);
   await collection.deleteMany({ _id: new ObjectId(_id) });

test/db/db.test.ts

@@ -19,12 +19,10 @@ import { SAMPLE_REPO } from '../../src/proxy/constants';
 
 vi.mock('../../src/db/mongo', () => ({
   getRepoByUrl: vi.fn(),
-  backfillRepoDates: vi.fn().mockResolvedValue(0),
 }));
 
 vi.mock('../../src/db/file', () => ({
   getRepoByUrl: vi.fn(),
-  backfillRepoDates: vi.fn().mockResolvedValue(0),
 }));
 
 vi.mock('../../src/config', () => ({

test/db/repo.date-fields.test.ts

@@ -18,13 +18,6 @@ import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
 import * as repoModule from '../../src/db/file/repo';
 import { Repo } from '../../src/db/types';
 
-vi.mock('../../src/db/mongo/helper', () => ({
-  connect: vi.fn(),
-}));
-
-import { connect } from '../../src/db/mongo/helper';
-import * as mongoRepo from '../../src/db/mongo/repo';
-
 describe('Repo dateCreated / lastModified (#1486)', () => {
   beforeEach(() => {
     vi.clearAllMocks();
@@ -115,89 +108,4 @@ describe('Repo dateCreated / lastModified (#1486)', () => {
 
     expect(sorted.map((r) => r.name)).toEqual(['stale', 'mid', 'fresh']);
   });
-
-  it('NeDB backfillRepoDates fills missing fields without dropping other props', async () => {
-    const docs: Repo[] = [
-      {
-        project: 'finos',
-        name: 'legacy',
-        url: 'https://github.com/finos/legacy.git',
-        users: { canPush: ['bob'], canAuthorise: [] },
-        _id: 'legacy-id',
-      },
-      {
-        project: 'finos',
-        name: 'partial',
-        url: 'https://github.com/finos/partial.git',
-        users: { canPush: [], canAuthorise: [] },
-        dateCreated: '2021-06-01T00:00:00.000Z',
-        _id: 'partial-id',
-      },
-    ];
-
-    vi.spyOn(repoModule.db, 'find').mockImplementation((_q: unknown, cb: any) => cb(null, docs));
-
-    const patches: Array<{ id: string; set: Record<string, string> }> = [];
-    vi.spyOn(repoModule.db, 'update').mockImplementation(
-      (q: any, update: any, _o: unknown, cb: any) => {
-        patches.push({ id: q._id, set: update.$set });
-        cb(null, 1);
-      },
-    );
-
-    const fallback = '1970-01-01T00:00:00.000Z';
-    const updated = await repoModule.backfillRepoDates(fallback);
-
-    expect(updated).toBe(2);
-    expect(patches).toEqual(
-      expect.arrayContaining([
-        {
-          id: 'legacy-id',
-          set: { dateCreated: fallback, lastModified: fallback },
-        },
-        {
-          id: 'partial-id',
-          set: {
-            dateCreated: '2021-06-01T00:00:00.000Z',
-            lastModified: '2021-06-01T00:00:00.000Z',
-          },
-        },
-      ]),
-    );
-  });
-
-  it('NeDB backfillRepoDates is a no-op when all repos already have dates', async () => {
-    vi.spyOn(repoModule.db, 'find').mockImplementation((_q: unknown, cb: any) => cb(null, []));
-    const updateSpy = vi.spyOn(repoModule.db, 'update');
-
-    const updated = await repoModule.backfillRepoDates();
-
-    expect(updated).toBe(0);
-    expect(updateSpy).not.toHaveBeenCalled();
-  });
-
-  it('Mongo backfillRepoDates uses updateMany with $ifNull pipeline', async () => {
-    const updateMany = vi.fn().mockResolvedValue({ modifiedCount: 3 });
-    vi.mocked(connect).mockResolvedValue({ updateMany } as any);
-
-    const fallback = '1970-01-01T00:00:00.000Z';
-    const updated = await mongoRepo.backfillRepoDates(fallback);
-
-    expect(updated).toBe(3);
-    expect(updateMany).toHaveBeenCalledWith(
-      {
-        $or: [{ dateCreated: { $exists: false } }, { lastModified: { $exists: false } }],
-      },
-      [
-        {
-          $set: {
-            dateCreated: { $ifNull: ['$dateCreated', fallback] },
-            lastModified: {
-              $ifNull: ['$lastModified', { $ifNull: ['$dateCreated', fallback] }],
-            },
-          },
-        },
-      ],
-    );
-  });
 });