[Bug]: pkg.installed fails on freebsd

[network-shark]

What happened?

When executing pkg.installed it returns false even if the application is installed correctly.

state returns Result: False

root@salt:~# salt newjail2026 state.apply forgejo.init  saltenv=dev
jid: 20260402202333686875
newjail2026:
----------
          ID: install
    Function: pkg.installed
        Name: forgejo
      Result: False
     Comment: The following packages failed to install/update: forgejo=14.0.3
     Started: 22:22:48.401852
    Duration: 2774.416 ms
     Changes:
              ----------
              forgejo:
                  ----------
                  new:
                      14.0.3
                  old:
----------

truncated ....

Succeeded: 4 (changed=1)
Failed:    1
------------
Total states run:     5
Total run time:   3.323 s

Type of salt install

Official deb

Major version

3006.x

What supported OS are you seeing the problem on? Can select multiple. (If bug appears on an unsupported OS, please open a GitHub Discussion instead)

debian-11

salt --versions-report output

Salt Version

salt -V
Salt Version:
          Salt: 3006.9

Python Version:
        Python: 3.11.14 (main, Jan  1 2026, 01:04:56) [Clang 19.1.7 (https://github.com/llvm/llvm-project.git llvmorg-19.1.7-0-gcd7080

Dependency Versions:
          cffi: 1.17.1
      cherrypy: Not Installed
  cryptography: 45.0.7
      dateutil: 2.9.0
     docker-py: Not Installed
         gitdb: Not Installed
     gitpython: Not Installed
        Jinja2: 3.1.6
       libgit2: Not Installed
  looseversion: 1.3.0
      M2Crypto: Not Installed
          Mako: Not Installed
       msgpack: 1.1.2
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     packaging: 25.0
     pycparser: 2.23
      pycrypto: Not Installed
  pycryptodome: 3.23.0
        pygit2: Not Installed
  python-gnupg: Not Installed
        PyYAML: 6.0.3
         PyZMQ: 27.1.0
        relenv: Not Installed
         smmap: Not Installed
       timelib: Not Installed
       Tornado: 4.5.3
           ZMQ: 4.3.5

System Versions:
          dist: freebsd 15.0
        locale: utf-8
       machine: amd64
       release: 15.0-RELEASE-p2
        system: FreeBSD
       version: FreeBSD 15.0

[network-shark]

What I initially want.

install:
  pkg.installed:
    - name: 'forgejo'
    - version: {{vars.forgejo_app_version}}

This is not working. The bug above is raised.

The problem is that the version number is not handled properly it never reaches _fulfills_version_string , instead it matches the else case.

            cver = new_pkgs.get(pkgname)
            if not cver and pkgname in new_caps:
                cver = new_pkgs.get(new_caps.get(pkgname)[0])

Which makes cver a dict , not a list of versions.

To reach _fulfills_version_string cver has to be a version number.

this would make it work

    for pkgname, pkgver in desired.items():
        has_origin = "/" in pkgname
        if __grains__["os"] == "FreeBSD" and has_origin:
            cver = [k for k, v in new_pkgs.items() if v["origin"] == pkgname]
        **elif __grains__["os"] == "FreeBSD":
            cver = new_pkgs.get(pkgname).get('version')**

The problem is that the new_pkgs looks like this {'forgejo': {'origin': 'www/forgejo', 'version': ['14.0.3']} } .

the existing function with "has_origin is not working , because cver is a list of version numbers so that _fulfills_version_string can work with it. But in the list comprehension k is returned which is a name.... .

I don't want to change it , because it works.

With this syntax everything is fine except you can't specify a version and it is not idempotent.

install:
  pkg.installed:
    - name: 'www/forgejo'

Calling it with a version , it fails

install:
  pkg.installed:
    - name: 'www/forgejo'
    - version: {{vars.forgejo_app_version}}

Failure:

          ID: install
    Function: pkg.installed
        Name: www/forgejo
      Result: False
     Comment: Problem encountered installing package(s). Additional info follows:

              errors:
                  - pkg: No packages available to install matching 'www/forgejo-14.0.3' have been found in the repositories
     Started: 22:16:35.237644
    Duration: 2447.875 ms
     Changes:

There is no package www/forgejo-14.0.3 , the name is forgejo-14.0.3

Opinions ?

[bdrx312]

I am not sure if your reported problem is directly related, but _verify_install is called in 2 different places in states/pkg.py. Once with the result from list_downloaded and once with the results of list_pkgs.

https://github.com/network-shark/salt/blob/0b4b59c2d107b24865033d6d58a43fd9beac2097/salt/states/pkg.py#L2303-L2304

    new_pkgs = __salt__["pkg.list_downloaded"](**kwargs)
    _ok, failed = _verify_install(targets, new_pkgs, ignore_epoch=ignore_epoch)

https://github.com/network-shark/salt/blob/0b4b59c2d107b24865033d6d58a43fd9beac2097/salt/states/pkg.py#L1974-L1984

        new_pkgs = __salt__["pkg.list_pkgs"](versions_as_list=True, **kwargs)
        if (
            kwargs.get("resolve_capabilities", False)
            and "pkg.list_provides" in __salt__
        ):
            new_caps = __salt__["pkg.list_provides"](**kwargs)
        else:
            new_caps = {}
        _ok, failed = _verify_install(
            desired, new_pkgs, ignore_epoch=ignore_epoch, new_caps=new_caps
        )

However the aptpkg module implementation of list_pkgs (with versions_as_list=True) and list_downloaded return 2 different dict datastructures.

https://github.com/saltstack/salt/blob/24a4cfac284251d0da87c308b78e73d60b5f4d54/salt/modules/aptpkg.py

I think list_pkgs returns a dict of key package name with value list of versions. list_downloaded returns this structure:

            ret.setdefault(pkg_info["name"], {})[pkg_info["version"]] = {
                "path": package_path,
                "size": os.path.getsize(package_path),
                "creation_date_time_t": pkg_timestamp,
                "creation_date_time": datetime.datetime.utcfromtimestamp(
                    pkg_timestamp
                ).isoformat(),
            }

[bdrx312]

As a potential work around you could try:

install:
  pkg.installed:
    - pkgs:
      -  'forgejo': '{{vars.forgejo_app_version}}'

but I expect that would go into the same code flow and have the same problem.